Commits

Steve Borho committed 8b64a06

hgemail: remove redundant close method, connect finished signal to deleteLater

This connection has helped other dialogs from crashing (mysteriously). So we'll
see if this aids the crashes some have been reporting when they click the send
button.

  • Participants
  • Parent commits 181c004
  • Branches stable

Comments (0)

Files changed (1)

File tortoisehg/hgqt/hgemail.py

         for e in ('to_edit', 'from_edit'):
             getattr(self._qui, e).editTextChanged.connect(self._updateforms)
 
-    def close(self):
-        super(EmailDialog, self).accept()
-
     def accept(self):
         # TODO: want to pass patchbombopts directly
         def cmdargs(opts):
             cmd = cmdui.Dialog(['email'] + cmdargs(opts), parent=self)
             cmd.setWindowTitle(_('Sending Email'))
             cmd.setShowOutput(False)
+            cmd.finished.connect(cmd.deleteLater)
             if cmd.exec_():
                 self._writehistory()
                 super(EmailDialog, self).accept()