Commits

Yuya Nishihara committed 9517516

logcolumns: eliminate unnecessary references

  • Participants
  • Parent commits a4e2360

Comments (0)

Files changed (1)

File tortoisehg/hgqt/repoview.py

         QDialog.__init__(self, parent)
         all = model._allcolumns
         colnames = model._allcolnames
-        self.curcolumns = curcolumns
 
         self.setWindowTitle(name)
         self.setWindowFlags(self.windowFlags() & \
                             ~Qt.WindowContextHelpButtonHint)
         self.setMinimumSize(250, 265)
 
-        self.disabled = [c for c in all if c not in self.curcolumns]
+        disabled = [c for c in all if c not in curcolumns]
 
         layout = QVBoxLayout()
         layout.setContentsMargins(5, 5, 5, 5)
 
         list = QListWidget()
         # enabled cols are listed in sorted order, disabled are listed last
-        for c in self.curcolumns + self.disabled:
+        for c in curcolumns + disabled:
             item = QListWidgetItem(colnames[c])
             item.columnid = c
             item.setFlags(Qt.ItemIsSelectable |
                           Qt.ItemIsEnabled |
                           Qt.ItemIsDragEnabled |
                           Qt.ItemIsUserCheckable)
-            if c in self.curcolumns:
+            if c in curcolumns:
                 item.setCheckState(Qt.Checked)
             else:
                 item.setCheckState(Qt.Unchecked)
         # dialog buttons
         BB = QDialogButtonBox
         bb = QDialogButtonBox(BB.Ok|BB.Cancel)
-        self.apply_button = bb.button(BB.Apply)
         bb.accepted.connect(self.accept)
         bb.rejected.connect(self.reject)
         bb.button(BB.Ok).setDefault(True)