Commits

Anonymous committed a47900f

commit: do not show the "Issue Tracker" related options on the "Selected Options" field

The issue tracker options are not passed to the commit command. Therefore they
are not very interesting to the user since they do not affect what the commit
will do.

In addition they are not really "selected options", because they are not set
through the "Options" dialog, but through the Settings dialog, which means that
they are not temporary (i.e. they are always applied). Because of this if you
configure an issue tracker you will always get the "Selected Options" field.

Finally, they are often very long because they include the (long) name of the
issue tracker pluggin object. Because they are so long they reduce the file
list size to its minimum size, which makes the refresh button unavailable.

For these reasons it is best not to show those options in the "Selected
Options" field.

  • Participants
  • Parent commits 25b3139
  • Branches stable

Comments (0)

Files changed (1)

File tortoisehg/hgqt/commit.py

         # Update options label
         opts = []
         for opt, value in self.opts.iteritems():
-            if value is True:
-                opts.append('--' + opt)
-            elif value:
-                opts.append('--%s=%s' % (opt, value))
+            if not opt.startswith('bugtraq'):
+                # The "bugtraq" related options are not very interesting as they are not passed to the commit command
+                # The user will already see an "issue tracker" button indicating that the bug tracker is active
+                if value is True:
+                    opts.append('--' + opt)
+                elif value:
+                    opts.append('--%s=%s' % (opt, value))
+
         self.optionslabel.setText(' '.join(opts))
         self.optionslabel.setVisible(bool(opts))
         self.optionslabelhdr.setVisible(bool(opts))