Yuya Nishihara avatar Yuya Nishihara committed c38e7c5

thgstrip: remove lambda slots which prevent garbage collection

Comments (0)

Files changed (2)

tortoisehg/hgqt/repowidget.py

                                    parent=self)
         dlg.showBusyIcon.connect(self.onShowBusyIcon)
         dlg.hideBusyIcon.connect(self.onHideBusyIcon)
-        dlg.finished.connect(dlg.deleteLater)
         dlg.exec_()
 
     def sendToReviewBoard(self):

tortoisehg/hgqt/thgstrip.py

         box.addWidget(buttons)
 
         # signal handlers
-        self.rev_combo.editTextChanged.connect(lambda *a: self.preview())
+        self.rev_combo.editTextChanged.connect(self.preview)
         self.rev_combo.lineEdit().returnPressed.connect(self.strip)
-        self.discard_chk.toggled.connect(lambda *a: self.preview())
+        self.discard_chk.toggled.connect(self.preview)
 
         # dialog setting
         self.setLayout(box)
         self.cslist.update(striprevs)
         return True
 
+    @pyqtSlot()
     def preview(self):
         if self.updatecslist():
             striprevs = self.cslist.curitems
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.