1. TortoiseHg
  2. TortoiseHg
  3. thg


Yuya Nishihara  committed e7f9633

sync: manage configChanged connection in C++ layer to avoid crash (fixes #2425)

Because `self.finishedfunc = finished` makes circular reference, Python part
of SyncWidget is not deleted immediately. So, configChanged() tries to create
PathsModel with parent=self, but here self is half dead.

This works around the problem by breaking up signal connection when C++ object
is deleted. But still SyncWidget has a GC issue.

  • Participants
  • Parent commits 8d357e3
  • Branches stable

Comments (0)

Files changed (1)

File tortoisehg/hgqt/sync.py

View file
  • Ignore whitespace
             index = 0
+    @pyqtSlot()
     def configChanged(self):
         'Repository is reporting its config files have changed'