1. TortoiseHg
  2. TortoiseHg
  3. thg


Yuya Nishihara  committed fdde19e

repomodel: use old-style signal for QTimer.singleShot connection (fixes #2239)

PyQt 4.7.4 does not support new-style signal-signal connection for this case.

> v4.7.5 31st August 2010
> - A signal defined with pyqtSignal() can now be used with methods that make
> an internal call to QObject::connect(), e.g. QTimer.singleShot().

Also note that:

- QTimer.singleShot(0, lambda: self.filled.emit()) confuses lifetime of QObject
(refs #1267)
- QTimer.singleShot(0, self.filled.emit) segfaults if self has been destroyed

  • Participants
  • Parent commits d1be42d
  • Branches stable

Comments (0)

Files changed (1)

File tortoisehg/hgqt/repomodel.py

View file
  • Ignore whitespace
-        QTimer.singleShot(0, self.filled)
+        QTimer.singleShot(0, self, SIGNAL('filled()'))
     def reloadConfig(self):
         _ui = self.repo.ui