"Save Open Repositories on Exit" reacts badly with subrepos

Steve Borho avatarSteve Borho created an issue

To repo:

  1. enable "Save Open Repositories on Exit"
  2. open a subrepo repository
  3. close the workbench
  4. re-open the workbench, the subrepo has now been added to the default repository group.

Comments (3)

  1. Steve Borho

    workbench: do not reopen repos during startup until subrepos have been loaded into the registry (closes #1017)

    During startup the workbench gets the list of repos (and subrepos) that were open on the last session. It goes through the list, opening them one by one, and if any is not found on the registry, it adds it automatically adds it to the reporegistry default group.

    Before this patch, the reload operation was performed before the subrepos had been loaded into the registry. Thus if a subrepo was on the reopen list it would never be found on the registry, and thus it would always be added to the default group on startup.

    This patch simply changes the order in which the settings are read. The "Save open repositories on exit" setting is read after the "Show subrepos" setting has been read and acted upon.

    0b1377c8084f

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.