Issue #1420 resolved

Underlying C/C++ object has been deleted

Anonymous created an issue

{{{

!python

Mercurial version (1.9.3). TortoiseHg version (2.1.4) Command: --nofork workbench CWD: D:\Project_T\src_beta Encoding: cp1251 Extensions loaded: Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (6, 1, 7601, 2, 'Service Pack 1') Processor architecture: x86 ** Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\update.pyo", line 292, in update File "tortoisehg\hgqt\update.pyo", line 283, in confirmupdate RuntimeError: underlying C/C++ object has been deleted

}}}

Comments (10)

  1. Yuya Nishihara

    update: don't expose confirmation buttons to ease garbage tracking (refs #1420)

    Because confirmupdate() does not return dlg, dlg may be deleted soon but still its child buttons are referenced. I don't think this should cause #1420, but it will complicate object tracking more than necessary.

    This patch changes confirmupdate() to return the name of the clicked button instead the button itself.

    → <<cset 2f55da66a739>>

  2. Log in to comment