Can't diff between file revisions in File Log Viewer -- GUI misleading

Anonymous avatarAnonymous created an issue

If you bring up the file log viewer for a file (right-click in Explorer, select TortoiseHg - Revision History) you get a dialog that shows you a list of the file revisions. You can multi-select two revisions, but if you then select "Visual Diff File" you don't get a visual diff of those two revisions. It instead shows a diff one of just one revision.

So not only is there no way to diff between two different revisions, but the GUI is misleading in that it lets you multi-select lines implying that you will be viewing a diff of those two revisions. (If you're not going to support operations involving multiple revisions, then don't allow the user to select multiple revisions.)

Comments (8)

  1. Jason McKesson

    Is this going to get fixed? It seems like such a simple thing: TortoiseHg already has the "compare revisions" dialog. Just have a button in the dialog to bring this up.

  2. Steve Borho

    Looking at this today, I don't understand why this dialog allows multiple row selections when none of the dialog can deal with multiple selections.

  3. Steve Borho

    I decided to make the dialog consistent in the short term, and disabled multi-selection until the dialog actually supports multiple selections properly

  4. Angel Ezquerra

    filedialogs: add multi-selection menu (fixes #1871)

    This change backs out bcf0854d848c6534 and adds a new menu which is shown when more than one item is selected. The menu shows two options:

    • Diff selected changesets...
    • Diff selected file revisions...

    Ideally it should not be possible to select more than two revisions. However, for now if more than two revisions are selected and the user right clicks the context menu will not be shown and insted a message will be shown on the status bar indicating that you cannot select more than two revisions.

    The code to generate the menus could be improved a lot, but that should be left for another revision.

    → <<cset 935f86ada84d>>

  5. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.