Workbench: fails to push new branch if "--pushafter=default" set

Ian Kemp avatarIan Kemp created an issue
  1. Open Workbench on an existing repo and navigate to the Commit view.
  2. Click the "Branch" button, select "Open a new named branch" and type any name into the field. Click OK.
  3. Click the "Options" button and check the "Push After Commit:" option. In the textfield, type "default" without quotes. Click OK.
  4. Enter any commit message then click the "Commit" button.

Expected result: Workbench detects I'm pushing a new branch and prompts me with a dialog asking me if I really want to do this (similar to when "--pushafter=default" is not set and I do a commit, then push)

Actual result: push fails because Workbench invokes hg.exe without passing the "--new-branch" argument

Reproducible: always

Notes: the current "push new branch" behavior is a little retarded, in that it tries to push, then gets an error from hg telling it to use --new-branch, then pops up a dialog asking you if you actually want to push, and then only if you confirm does it actually push the new branch. Essentially it's doing a superfluous push, which it shouldn't need to do because it knows that a new branch is being pushed.

Comments (5)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.