Synchronize widget opens with a big delay

Ruslan Yushchenko avatarRuslan Yushchenko created an issue

Hi, When the synchronization path list is filled with Windows network paths (e.g.
COMPUTER\Folder1\Folder2) that leads nowhere (i.e. computer is offline), the synchronization widget opens with a big delay.

I presume the synchronization paths are checked every time the widget opens and the delay is caused by a connection timeout. Maybe this check is not that necessary anyway?

Comments (11)

  1. Ruslan Yushchenko

    Thank you for the tip. I tried it, but unfortunately disabling this option doesn't suppress the delay. I've also noticed that this delay appears only when the button is clicked for the first time once a particular repository is open. Subsequent clicks on that button opens the widget in instant.

  2. Ruslan Yushchenko

    I tried to comment out this check, leaving only "known.add(path)". Interestingly, this removed delay from only one of two repos. It seems that there is another check responsible for the delay:

    https://bitbucket.org/tortoisehg/thg/src/7098288b81d9/tortoisehg/hgqt/sync.py#cl-477

    Removing both checks had finally made this widget refresh instantly. I am not sure whatever the check is necessary anyway, because it seems commenting these lines affected nothing else.

  3. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.