Workbench, reversion list get slow when showing 'Changes' column for large repo.

xpol avatarxpol created an issue

I tested under the follow repos:

  1. 1G+ repo with 10k+ files
  2. 300M+ repo with 2K files.

Both repo have lots of small (average 10kb) binary files and < 400 C source files.


  1. Open workbench, add 'Changes' column in the reversion list.
  2. Scroll up/down the reversion list, the list is slowly and not smooth, and even make the whole workbench freeze in the 1G+ repo.

I guess the process of get the changes information needs a bit optimize. So that the scrolling would get smooth.

Comments (4)

  1. Yuya Nishihara

    Currently changes column uses repo.status(), which is slow for repo containing large number of files, ~100msec for 30k files.

    Maybe we can switch to lightweight (but less detailed) algorithm for large repos. For example, ctx.files() has no extra cost but cannot distinguish modified/added/removed state.

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.