Issue #3406 resolved

Tristate issue with check all (again)

Marc Schlaich avatarMarc Schlaich created an issue

Steps to reproduce:

  • Have two changed files, check all is checked
  • Revert one file
  • Expected: Check all is still checked
  • Actual: Check all goes to tristate (square) and is now completely broken until refresh (as it toggles between tristate and checked state)

Comments (3)

  1. Yuya Nishihara

    status: sync partials table to model on updateModel (fixes #3406)

    If partials table has files which are not listed in wctx model, updatePartials will write invalid entry to model.checked table. As a result, checkAllNoneBtn no longer work properly.

    This adds several assertions to check consistency between model rows and checked table.

    Eventually partials table will be merged to WctxModel and these assertions will be removed.

    → <<cset 134cefd6a83c>>

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.