Issue #3697 resolved

No workbench refresh when first commit is rolled back

Marc Schlaich
created an issue

Steps:

  1. create new repo
  2. make a commit
  3. rollback commit (Ctrl+U)

Result: Workbench state doesn't change, manual refresh is required.

Comments (3)

  1. Yuya Nishihara

    Confirmed.

    It happens because hg rollback of the initial commit removes almost all store files, so there are no reliable mtime source.

    Related: #3340 in that rollback is the command to control low-level transaction.

  2. Yuya Nishihara

    repowatcher: implement table-based change detector (refs #3697)

    This will greatly simplify the precedence of check functions defined in pollStatus(). All emissions of repositoryChanged(flags) will be ported to table-based detector and the original check functions will be removed.

    Unlike the original checker, it will keep mtime of repository files separately so that it will be able to notice deleted files, issue #3697.

    → <<cset 8eb328f9e7a4>>

  3. Log in to comment