crash report when adding too many files

Issue #132 resolved
Eduard-Cristian Stefan
created an issue

{{{

!python

Please report this bug to http://bitbucket.org/tortoisehg/thg/issues Mercurial version (1.7.5+96-6169493ac3f9). TortoiseHg version (1.1.9.1+179-245bbfcfcec6) Command: CWD: K:\temp\repo Extensions loaded: convert, extdiff, mq, patchbomb, rebase, transplant Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (6, 1, 7600, 2, '') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "k:\qt\thg\tortoisehg\hgqt\wctxactions.py", line 35, in <lambda> action.run = lambda: run(action.args) File "k:\qt\thg\tortoisehg\hgqt\wctxactions.py", line 104, in run notify = func(parent, hu, repo, files) File "k:\qt\thg\tortoisehg\hgqt\wctxactions.py", line 258, in add commands.add(ui, repo, files) File "k:\qt\hg\mercurial\commands.py", line 49, in add m = cmdutil.match(repo, pats, opts) File "k:\qt\hg\mercurial\cmdutil.py", line 268, in match auditor=repo.auditor) File "k:\qt\hg\mercurial\match.py", line 54, in init self.patternspat, pm = _buildmatch(pats, '$') File "k:\qt\hg\mercurial\match.py", line 257, in _buildmatch pata, a = _buildmatch(pats[:l//2], tail), ValueError: need more than 1 value to unpack

}}}

Comments (11)

  1. Eduard-Cristian Stefan reporter

    It's not the number of files:

    • when adding Django 1.2.5 the error appears when adding 350 files (of various folder depth)
    • for a single folder with a name length of 100 chars, the error appears when adding 250 files (just a test, not a real case)
    • mercurial has no problem adding all the files in both cases
    • I can add all the files with thg in smaller chunks (like 100 files at a time)
  2. Steve Borho

    I spoke too soon, I forgot wctxactions has a run() wrapper that changes directory to the repo root while the command runs. I'll have to try to reproduce this.

  3. Log in to comment