1. TortoiseHg
  2. TortoiseHg
  3. thg
  4. Issues
Issue #1516 resolved

Unicode character in commit message fail commit

Anonymous created an issue

If I switch to Japanese IME input and insert say, a Unicode spacing or anything non-ASCII trying to commit gives me this message. I understand that commit messages may be ASCII only but the error is rather cryptic to the end user (it took me sometimes to figure out I had an accidental Unicode double-width space character in my commit message). Regards.

{{{

!python

Mercurial version (2.0.2). TortoiseHg version (2.2.2) Command: CWD: C:\Windows\system32 Encoding: cp1252 Extensions loaded: fetch, mercurial_keyring, hgshelve Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:13:38) [MSC v.1500 64 bit (AMD64)] Windows version: (6, 1, 7601, 2, 'Service Pack 1') Processor architecture: x64 ** Qt-4.7.4 PyQt-4.8.6 Traceback (most recent call last): File "tortoisehg\hgqt\thread.pyo", line 264, in run TypeError: sequence item 6: expected string, QString found

}}}

Comments (5)

  1. Anonymous

    I noted this bug was already submitted under various forms/variations. What I'd like to state is that the error message itself is unusually user-unfriendly, and that could be addressed separately from fixing Unicode support. Thanks :)

  2. Log in to comment