1. TortoiseHg
  2. TortoiseHg
  3. thg
  4. Issues
Issue #1673 resolved

incorrect behaviour of "goto current rev" button

Johan Samyn
created an issue

The first time one clicks that button, and the current rev is not the selected one, it has the expected effect. But all next clicks then remove the highlighting of the current rev, leaving only a dotted rectangle around the content of one of the columns of that current rev. And I don't think that is what's intended ?

Comments (4)

  1. Johan Samyn reporter
    • changed status to open

    This is only solved when using the 'home' button in the toolbar. Using the keyboard Ctrl-P one ends up seeing 2 rows shown as selected (if they are near enough). At least on Win7, don't know about Linux. I noticed an F5 clears the old selected row.

    As I guess always doing the F5 logic after the Ctrl-P may be too expensive, maybe we should check if we already are at the 'current rev', and just return in that case (instead of the solution André committed) ? What do others think ?

  2. Yuya Nishihara

    Using the keyboard Ctrl-P one ends up seeing 2 rows shown as selected

    It happens because view.setCurrentIndex() recognizes Ctrl key as multi-select. (try Ctrl+ 'home' button) Maybe we should use selectionModel in place of view.

  3. Log in to comment