Issue #2155 resolved

TortoiseHg stall with nearly "text" file

Jean_Francois_Coulon
created an issue

After having updated to v2.5, I've an issue when in the commit tab when I select the attached file, the workbench stall indefinitely. This is a file that used to be visualized without any problem prior the updating to v2.5. It is usually seen as a text file by Tortoise as other files of the same kind in my project. After a commit of the file, then modified it, it works again. I suspect the issue to come from the new algorithm in determining whether a file is text or binary.

Comments (9)

  1. Jean_Francois_Coulon reporter

    (Reply via jfc3...@yahoo.com):

    I do not remember but the first time I installed it on my Win7 Pc was on march this year. So I guess it was between2.3.1 and 2.4.1. I read from the release notes that in 2.5 over 2.4 there is filedata: add new binary detection heuristic, based on the max line length. Can'tit be related to the issue I had with this file that is not a "standard" text file (many characters are not usual). This is the application that didn't respond at all (I had each time to kill it). The first time, I waited several minute before killing it. I have reproduced the issue several time until I decided to commit then modify the file.

    ______ From: Yuya Nishihara <issues-reply@bitbucket.org> To: jfc38mbx-bitbucket@yahoo.com Sent: Wednesday, September 19, 2012 4:08 PM Subject: Re: [tortoisehg/thg] TortoiseHg stall with nearly "text" file (issue #2155)

  2. Yuya Nishihara

    Probably it depends on Qt (or QScintilla?) version.

    • TortoiseHg 2.3.1, Python-2.6.6, PyQt-4.8.6, Qt-4.7.4 (msi) => fast
    • TortoiseHg 2.3.1, Python-2.7.2, PyQt-4.9, Qt-4.8.0 (source) => a bit slow
    • TortoiseHg 2.5, Python-2.7.3, PyQt-4.9.1, Qt-4.8.0 (msi) => a bit slow
  3. Jean_Francois_Coulon reporter

    (Reply via jfc3...@yahoo.com):

    It uses Qt-4.8.0. But is not a question of being a bit slow. It more seems like on certain condition(s) it enters an endless loop. It usually processes what it needs to be done with that very same file in a small fraction of a second.

    ______ From: Yuya Nishihara <issues-reply@bitbucket.org> To: jfc38mbx-bitbucket@yahoo.com Sent: Monday, September 24, 2012 4:44 PM Subject: Re: [tortoisehg/thg] TortoiseHg stall with nearly "text" file (issue #2155)

  4. Jean_Francois_Coulon reporter

    (Reply via jfc3...@yahoo.com):

    Yes the issue is just with a single version of the file. I have several versions of it since then that have no problem. But if I just select the "issue triggering" version, the workbench enters what seems to be an infinite loop. Jean-Francois

    ______ From: Yuya Nishihara <issues-reply@bitbucket.org> To: jfc38mbx-bitbucket@yahoo.com Sent: Tuesday, September 25, 2012 5:03 PM Subject: Re: [tortoisehg/thg] TortoiseHg stall with nearly "text" file (issue #2155)

  5. Yuya Nishihara

    Probably this was caused by the bug of QScintilla or Pygments.

    TortoiseHg 2.10.2 bundles new versions of these libraries. If the problem still happen, please reopen this issue.

  6. Log in to comment