Issue #2166 resolved

'FileRevModel' object has no attribute 'timerHandle'

Александр Дьяченко
created an issue



Mercurial version (2.3.1). TortoiseHg version (2.5) Command: CWD: C:\Program Files\TortoiseHg Encoding: cp1251 Extensions loaded: rebase, convert Python version: 2.7.3 (default, Apr 10 2012, 23:24:47) [MSC v.1500 64 bit (AMD64)] Windows version: sys.getwindowsversion(major=6, minor=2, build=8400, platform=2, service_pack='') Processor architecture: x64 ** Qt-4.8.0 PyQt-4.9.1 Traceback (most recent call last): File "tortoisehg\hgqt\repomodel.pyo", line 256, in timerEvent AttributeError: 'FileRevModel' object has no attribute 'timerHandle'


Comments (5)

  1. Steve Borho

    filerevmodel: remove unwanted and unstopped startTimer() (refs #2166)

    Since d7e163b8afac, which renamed _fill_timer to timerHandle in super class, _fill_timer is no-op and never stopped.

    I suspect that unstopped _fill_timer hit some bug of PyQt, say, timerEvent() was somehow triggered while destroying Python object, and caused #2166.

    Currently revision graph is loaded on demand, this startTimer() is no longer needed.

    → <<cset 6d70226a502d>>

  2. Log in to comment