1. TortoiseHg
  2. TortoiseHg
  3. thg
  4. Issues
Issue #230 resolved

About Dialog Hangs on Close

Anonymous created an issue

1) Open the About dialog 2) Immediately click the Close button The window will not close. This will hang any parent TortoiseHg window and Windows (the O.S.) may detect the program is not responding.

(Maybe it's waiting for the update thread to finish (?), but this seems to be a bad user experience. Possibly cancel on the update thread, if it's not finished when close is clicked...?)

Comments (6)

  1. Steve Borho

    The thread is not cancelable because of Python's blocking behavior. So long as the thread is blocked waiting on an O/S call the interpreter cannot break it. And if we try to close the app before the thread has stopped, Qt is likely to crash. It's truly annoying.

    I just had a thought. Perhaps we should be using a QTcpSocket or QNetworkRequest instead of a Python thread for this. It would alleviate the problem in the About dialog, anyway.

  2. Yuya Nishihara

    I just had a thought. Perhaps we should be using a QTcpSocket or QNetworkRequest instead of a Python thread for this.

    Is it okay to depend on QtNetwork4.dll? If so, I'll try fixing this issue.

  3. Log in to comment