1. TortoiseHg
  2. TortoiseHg
  3. thg
  4. Issues
Issue #277 resolved

create tag error report in using workbench

jeffrey fan
created an issue

In workbench, I select a reversion and make a tag, it shows tag dialog. I input the tag name and push add button, show a error report: {{{

!python

Please report this bug to http://bitbucket.org/tortoisehg/thg/issues Mercurial version (1.8+21-a87a0fcb412f). TortoiseHg version (2.0+118-96a439e69cf1) Command: --nofork workbench CWD: F:\githgtest Extensions loaded: fixfrozenexts Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 ** Qt-4.7.1 PyQt-4.8.2 Traceback (most recent call last): File "tortoisehg\hgqt\tag.pyo", line 321, in reject TypeError: disconnect() failed between 'repositoryChanged' and 'refresh'

}}}

some times show:

{{{

!python

Please report this bug to http://bitbucket.org/tortoisehg/thg/issues Mercurial version (1.8+21-a87a0fcb412f). TortoiseHg version (2.0+118-96a439e69cf1) Command: --nofork workbench CWD: F:\githgtest Extensions loaded: fixfrozenexts Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 ** Qt-4.7.1 PyQt-4.8.2 Traceback (most recent call last): File "tortoisehg\hgqt\tag.pyo", line 322, in reject NameError: global name 'BookmarkDialog' is not defined

}}}

Comments (4)

  1. Steve Borho

    tag: fix cut-paste error (closes #277)

    My guess is that this bug prevented QDialog.reject() from being called, so the dialog was not closed the first time. The second time reject() was called the disconnect error was thrown, because the signal was already disconnected.

    da42974008e6

  2. Log in to comment