Issue #33 open

thg shortcuts outdated

Johan Samyn
created an issue

A few days ago I installed Thg in a Win7 virtual machine. I created a desktop shortcut (via rightclick the Workbench entry as installed and choosing 'send to'), and also pinned the Workbench to the startmanu. When I install a newer thg nightly build, those shortcuts are no longer valid. Windows shows a message "Problem with shortcut - This action is only valid for products that are currently instgalled." for both of them. This is something I never experienced with shortcuts created the same way for other software, nor with the gtk version.

Comments (7)

  1. Johan Samyn reporter

    I already removed them to install others, to make it work. So I downloaded the very latest msi, and did it all over. With the same result. But no, running the repair mode does not solve it. It even needed a restart to complete the repair. Though I am an admin on that Win7 virtual machine.

  2. Johan Samyn reporter

    Creating shortcuts manually, filling in the necessary info myself, instead of generating it via the cmenu of the existing Start Menu entry, indeed keeps the desktop and taskbar shortcuts when installing an upgrade.

  3. Steve Borho

    I tried a crude attempt to fix this before release by changing the Workbench shortcut to be non-advertising. See

    diff --git a/win32/wix/tortoisehg.wxs b/win32/wix/tortoisehg.wxs
    --- a/win32/wix/tortoisehg.wxs
    +++ b/win32/wix/tortoisehg.wxs
    @@ -100,7 +100,7 @@
                 <File Id='thgwEXE' Name='thgw.exe' Source='dist\thgw.exe' />
                 <Shortcut Id="thgStartMenu" Directory="ProgramMenuDir"
                           Name="TortoiseHg Workbench"
    -                      Icon="thgIcon.ico" IconIndex="0" Advertise="yes"
    +                      Icon="thgIcon.ico" IconIndex="0" Advertise="no"
               <Component Id='ExtensionVersions' Guid='$(var.ExtensionVersions.guid)

    However this generates ICE warnings:

    C:\thg-winbuild\build-thg\win32\wix\tortoisehg.wxs(99) : error LGHT0204 : ICE43:
     Component WinExecutable has non-advertised shortcuts. It should use a registry
    key under HKCU as its KeyPath, not a file.
    C:\thg-winbuild\build-thg\win32\wix\tortoisehg.wxs(99) : error LGHT0204 : ICE57:
     Component 'WinExecutable' has both per-user and per-machine data with a per-mac
    hine KeyPath.

    Perhaps this can be resolved for 2.0.1

  4. Log in to comment