1. TortoiseHg
  2. TortoiseHg
  3. thg
Issue #3358 resolved

Diff view: Error when selecting text and moving mouse over left border

Nathan Rusch
created an issue

In the file diff pane:

  1. Click and hold to start text selection
  2. While holding mouse button, move mouse cursor over left pane border
    ** Mercurial version (2.7.1+14-21a8a63bc074).  TortoiseHg version (2.9.1)
    ** Command: log
    ** CWD: /Volumes/sv-dev01/devRepo/ruschn
    ** Encoding: UTF-8
    ** Extensions loaded: hgk, share, extdiff, graphlog, mq, lumahg.shares, lumahg.fixHgPerms, prompt, lumahg.autopilot
    ** Python version: 2.7.1 (r271:86832, Apr 12 2011, 16:15:16) [GCC 4.6.0 20110331 (Red Hat 4.6.0-2)]
    ** System: Linux ws-082 2.6.40.3-0.fc15.x86_64 #1 SMP Tue Aug 16 04:10:59 UTC 2011 x86_64
    ** Qt-4.7.4 PyQt-4.8.6 QScintilla-2.4.6
    Traceback (most recent call last):
      File ".../python/thirdParty/tortoisehg-2.9/tortoisehg/hgqt/fileview.py", line 1074, in mouseMoveEvent
        self._emitRevisionHintAtLine(self.lineNearPoint(event.pos()))
      File ".../python/thirdParty/tortoisehg-2.9/tortoisehg/hgqt/qscilib.py", line 410, in lineNearPoint
        point.x(), point.y())
    TypeError: arguments did not match any overloaded call:
      QsciScintillaBase.SendScintilla(int, int wParam=0, int lParam=0): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, int, sip.voidptr): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, int, str): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, str): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, str, str): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, int): too many arguments
      QsciScintillaBase.SendScintilla(int, int, int, str): not enough arguments
      QsciScintillaBase.SendScintilla(int, int, QColor): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, QColor): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, int, QPainter, QRect, int, int): argument 2 has unexpected type 'int'
      QsciScintillaBase.SendScintilla(int, int, QPixmap): argument 2 has unexpected type 'int'

Comments (3)

  1. Yuya Nishihara

    qscilib: don't pass negative int as argument 2 of SendScintilla (fixes #3358)

    It seems old QsciScintilla (or sip) can't accept negative integer as unsigned long type. To be precise, it should do static_cast<unsigned long>(x), but it can simply ignore negative value, which is invalid position anyway.

    → <<cset 8e30381a941c>>

  2. Log in to comment