Issue #3406 resolved

Tristate issue with check all (again)

Marc Schlaich
created an issue

Steps to reproduce:

  • Have two changed files, check all is checked
  • Revert one file
  • Expected: Check all is still checked
  • Actual: Check all goes to tristate (square) and is now completely broken until refresh (as it toggles between tristate and checked state)

Comments (3)

  1. Yuya Nishihara

    status: sync partials table to model on updateModel (fixes #3406)

    If partials table has files which are not listed in wctx model, updatePartials will write invalid entry to model.checked table. As a result, checkAllNoneBtn no longer work properly.

    This adds several assertions to check consistency between model rows and checked table.

    Eventually partials table will be merged to WctxModel and these assertions will be removed.

    → <<cset 134cefd6a83c>>

  2. Log in to comment