1. TortoiseHg
  2. TortoiseHg
  3. thg
Issue #3621 new

Shelve tool does not always know about added/removed files

fschoenm
created an issue

The shelve tool seems to not always know the correct state of added/removed files in the repository.

I'm not 100 percent sure about the reproduction steps. The problem is that often the working directory state in the shelve tool does not correctly represent the real state when files have been added or removed/forgotten, even after refreshing.

I was able to observe the bug with the following steps:

  1. Change some existing file in the repository.
  2. Create and add a new file. Now there should be two uncommited changes.
  3. Open the shelve tool. It may or may not show both files. I had cases where the added file(s) only appeared after shelving the changes to existing files.
  4. Forget the file added in step 2.
  5. Open the shelve tool again. It still shows the forgotten file in its list.

I have the thgissue3595 fix installed as an hg extension at the moment.

Comments (3)

  1. Yuya Nishihara

    This is different (and long-standing?) issue than #3595. workingctx in the main thread is sometimes outdated.

    Probably you can work around this by refreshing the Workbench, not Shelve or Commit widget.

  2. Yuya Nishihara

    Your problem might be different from the one I found.

    Just in case, next time you get this problem, please try

    1. close Shelve dialog
    2. click refresh button of Workbench (or press F5)
    3. reopen Shelve dialog
  3. Log in to comment