1. TortoiseHg
  2. TortoiseHg
  3. thg
  4. Issues
Issue #3794 new

Add "Finish Patch" (QFinish) to Commit widget

Eric Palmitesta
created an issue

I have a small MQ interface workflow suggestion.

I took some time today to learn about Mercurial Queues (they are awesome), and while QNew/QRefresh (via Commit widget) and QPop/QPush (via changeset double-click) are intuitive, I couldn't figure out how to QFinish a patch. It took some googling before I realized the Finish Patch command is buried in the changeset context menu under Modify History. I expected it to be in the Commit widget dropdown.

My proposal is to

  • Add Finish Patch to the Commit widget dropdown
  • When selected
    • Set the Commit widget text to "QFinish"
    • Allow user to modify the commit message of that patch
  • When clicked, finishes the active patch

Comments (3)

  1. Yuya Nishihara

    In principle, "qfinish" is unrelated to "commit" or "qrefresh", so I don't like your suggestion.

    MQ requires expertise about patch management. I guess what we want is GUI frontend for better alternatives, e.g. "histedit", "evolve", "shelve", etc. Currently TortoiseHg only has "commit --amend".

  2. Eric Palmitesta reporter

    "In principle" is one thing, but "in practice" is what I'm pointing out.

    Here are three examples of users hunting for QFinish.

    https://www.mail-archive.com/tortoisehg-discuss@lists.sourceforge.net/msg02620.html "I really like the new Workbench, but I couldn't figure out how I qfinish a patch in the UI"

    http://sourceforge.net/p/tortoisehg/mailman/message/30490483/ "I can manage patches, apply and unapply them, but I can't figure out how to finish them"

    http://comments.gmane.org/gmane.comp.version-control.mercurial.tortoisehg.user/2388 "Is there another way to do a qfinish?"

  3. Log in to comment