searchtoolbar: Search ignores branch selection when filter checkbox is enabled

Issue #473 resolved
Angel Ezquerra
created an issue

When using the search toolbar if you select a branch on the branch selection combo, type a query and execute the search, the selected branch is ignored unless the filter checkbox is disabled.

That is, if you disable the filter checkbox you may get revisions that match your search query yet do not belong to the selected branch. The problem does not happen if you disable the filter checkbox, in which case only revisions from the selected branch are shown.

Comments (3)

  1. Anonymous

    Off the top of my head I can think of a pair of reasons why the current behavior is wrong:

    1. It breaks the symmetry between the "filtered" and the "unfiltered" modes: Currently the "unfiltered mode" correctly takes into account the selected branch, and it only shows you those revisions that match the search query _and_ belong to the selected branch. 2. If a user selected a particular branch, showing revisions from a different branch when you do a search is inconsistent: A colleague of mine was very confused by this behavior and in fact thought that it was due to the fact that he had transplanted some changes from one branch to another (to the one he had selected).

  2. Log in to comment