Issue #982 resolved

Bugs in right clicking working dir

bozr
created an issue

Some of the options presented when right clicking the working dir generate a crash report. The options in question are "Diff to local", "Merge with local", "Bookmark", "Backout", "Export patch", "Copy hash"

This subsequently produces the following traces:

{{{

!python

Mercurial version (1.9+10-e9264b45237d). TortoiseHg version (2.1.1) Command: --nofork workbench CWD: C:\Repositories\FSL-1025\src Extensions loaded: extdiff, purge, rebase, fetch, transplant, mq Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\repowidget.pyo", line 1504, in visualDiffToLocal TypeError: %d format: a number is required, not NoneType

}}}

{{{

!python

Mercurial version (1.9+10-e9264b45237d). TortoiseHg version (2.1.1) Command: --nofork workbench CWD: C:\Repositories\FSL-1025\src Extensions loaded: extdiff, purge, rebase, fetch, transplant, mq Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\merge.pyo", line 143, in initializePage UnboundLocalError: local variable 'otherCsInfo' referenced before assignment Traceback (most recent call last): File "tortoisehg\hgqt\merge.pyo", line 58, in pageChanged File "tortoisehg\hgqt\merge.pyo", line 265, in currentPage File "tortoisehg\hgqt\merge.pyo", line 273, in refresh AttributeError: 'SummaryPage' object has no attribute 'groups'

}}}

{{{

!python

Mercurial version (1.9+10-e9264b45237d). TortoiseHg version (2.1.1) Command: --nofork workbench CWD: C:\Repositories\FSL-1025\src Extensions loaded: extdiff, purge, rebase, fetch, transplant, mq Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\repowidget.pyo", line 1547, in bookmarkRevision File "tortoisehg\hgqt\bookmark.pyo", line 50, in init TypeError: %d format: a number is required, not NoneType

}}}

{{{

!python

Mercurial version (1.9+10-e9264b45237d). TortoiseHg version (2.1.1) Command: --nofork workbench CWD: C:\Repositories\FSL-1025\src Extensions loaded: extdiff, purge, rebase, fetch, transplant, mq Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\backout.pyo", line 118, in initializePage File "mercurial\revlog.pyo", line 694, in ancestor File "mercurial\revlog.pyo", line 305, in rev LookupError: 00changelog.i@None: no node Traceback (most recent call last): File "tortoisehg\hgqt\backout.pyo", line 53, in pageChanged File "tortoisehg\hgqt\backout.pyo", line 204, in currentPage File "tortoisehg\hgqt\backout.pyo", line 212, in refresh AttributeError: 'SummaryPage' object has no attribute 'groups'

}}}

{{{

!python

Mercurial version (1.9+10-e9264b45237d). TortoiseHg version (2.1.1) Command: --nofork workbench CWD: C:\Repositories\FSL-1025\src Extensions loaded: extdiff, purge, rebase, fetch, transplant, mq Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\repowidget.pyo", line 1485, in exportRevisions TypeError: %d format: a number is required, not NoneType

}}}

{{{

!python

Mercurial version (1.9+10-e9264b45237d). TortoiseHg version (2.1.1) Command: --nofork workbench CWD: C:\Repositories\FSL-1025\src Extensions loaded: extdiff, purge, rebase, fetch, transplant, mq Python version: 2.6.6 (r266:84297, Aug 24 2010, 18:46:32) [MSC v.1500 32 bit (Intel)] Windows version: (5, 1, 2600, 2, 'Service Pack 3') Processor architecture: x86 Qt-4.7.1 PyQt-4.8.3 Traceback (most recent call last): File "tortoisehg\hgqt\repowidget.pyo", line 1650, in copyHash TypeError: b2a_hex() argument 1 must be string or read-only buffer, not None

}}}

Comments (11)

  1. David Golub

    When I right-click on the working directory in the workbench, I see these options disabled. Does this occur for you with all repositories or only under certain circumstances?

  2. Anonymous

    I was able to reproduce this by:

    1. Open a fresh Hg Workbench window.
    2. Click the "Detect outgoing changesets" button.
    3. Wait until the process is finished.
    4. Right-click on the working directory.
  3. Log in to comment