Cannot get the Patch to work.

[Former user]

I cannot seem to get this patch to work....

I've tried installing the NPCBots.patch through the cmd. This didn't apply.

I've used Git's patch -p1 < NPCBots.patch to install it and that worked but when I tried to recompile the source (after using CMake to create a new Build folder) I either get errors or when I get in game none of the commands work.

I've freshly installed my source folder at least three times.

I've tried installing the patch with the unzipped patch .zip folders contents inside the Trinitycore Source folder.

I've tried not using CMake and just recompiling the core.

I've tried not recompiling the core and just using CMake to create the new files in the build directory.

What am I doing wrong? This is the ONLY patch I see myself needing, and the older versions sound like a pain in the butt to use. This is really frustrating....

[Former user]

So far, these are the errors that persist:

Error 2: error C2664: 'std::make_pair' : cannot convert parameter 1 from 'uint32' to 'uint32 &&' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp 3237

Error 3: error LNK1181: cannot open input file '..\game\Release\game.lib' C:\Build\src\server\worldserver\LINK

Not sure if that last one is a problem with the patch, though I don't get it without the patch so it probably is.

[trickerer]

It should be something to do with your compilier.
Provide some info, what os are you on and which compilier are you using.

[trickerer]

btw, try this:

    do
    {
        Field* fields = result->Fetch();
        uint32 temp_entry = fields[0].GetUInt32();
        uint32 temp_race = fields[1].GetUInt8();
-        npcBotsData.insert(std::make_pair<uint32, uint8>(temp_entry, temp_race));
+        npcBotsData.insert(std::make_pair(temp_entry, temp_race));
    } while (result->NextRow());

[Former user]

Windows 7 Home Premium x64.

Visual Studio 11 (2012 Express or something. It works for my OS).

I've been compiling in x32 but this is simply because CMake doesn't agree that my OS is 64 bit and believes I have a 32 bit system. Could this be the cause?

Where do I enter that snippet of code?

[trickerer]

C:\TrinityCore\src\server\game\Entities\Player\Player.cpp 3237 - exactly where this error is showing up

[Former user]

Line 3237 of the Player.cpp file.

But if you mean where in the compiler I don't know. I'd have to recompile it and I need to reinstall my MySQL server right now.

It's about halfway through the build. That I do know.

I'll get back to you as soon as possible with more information.

[trickerer]

You need just to replace one line of code and recompile

[Former user]

Oh, I gotcha. I'll try that in a minute.

Sorry, didn't read it right.

EDIT+: So it errored out again but this time I got two errors

*Error 2: error C2664: 'std::make_pair' : cannot convert parameter 1 from 'uint32' to 'uint32 &&' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp 3237

*Error 3: error C2675: unary '+' : 'std::pair<_Ty1,_Ty2>' does not define this operator or a conversion to a type acceptable to the predefined operator C:\TrinityCore\src\server\game\Entities\Player\Player.cpp 3238

I'm going to try freshly installing Trinitycore one more time tomorrow and then I'll patch after and see if that helps, but honestly I doubt it will.

[trickerer]

That's useless. I think this problem can be solved even while your Cmake is not using proper libs for 64-bit OS (as you don't get any more errors with std::pair).

Replace these lines carefully:

@@ -3228,18 +3229,19 @@ void Player::CreateNPCBot(uint8 bot_class)

    //find a bot to add
    //first check randomly selected bot, second check any bot we can add
-    std::set<std::pair<uint32, uint8> > npcBotsData;
+    typedef std::list< std::pair<uint32, uint8> > NpcBotsDataTemplate;
+    NpcBotsDataTemplate npcBotsData;
    do
    {
        Field* fields = result->Fetch();
        uint32 temp_entry = fields[0].GetUInt32();
-        uint32 temp_race = fields[1].GetUInt8();
-        npcBotsData.insert(std::make_pair<uint32, uint8>(temp_entry, temp_race));
+        uint8 temp_race = fields[1].GetUInt8();
+        npcBotsData.push_back(std::make_pair(temp_entry, temp_race));
    } while (result->NextRow());

    uint32 m_rand = urand(1, uint32(result->GetRowCount()));
    uint32 tmp_rand = 1;
-    std::set<std::pair<uint32, uint8> >::const_iterator itr = npcBotsData.begin();
+    std::list< std::pair<uint32, uint8> >::const_iterator itr = npcBotsData.begin();
    bool haveSameBot = false;
    bool moveback = false;
    bool forcedCheck = false;

See if you get errors for std::list as well

[Former user]

And again:

* (I've been getting this "Warning: warning LNK4006: _main already defined in bzip2recover.obj; second definition ignored C:\Build\dep\bzip2\bzip2.obj" warning. I figured it was nothing because it happens with the main build too and that still works. But this might be a problem as well) *

STARTING ON LINE 3229 FOR ALL CODE.

# When taking out the [-] code and replacing with [+] code. (32 bit [Stopped at first errors])

Error 2: error C2018: unknown character '0x40'  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3229
Error 3: error C2144: syntax error : 'void' should be preceded by ';'   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3229
Error 4: error C2144: syntax error : 'int' should be preceded by ';'    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error 5: error C2761: 'void Player::CreateNPCBot(uint8)' : member function redeclaration not allowed    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error 6: error C2146: syntax error : missing ';' before identifier 'NpcBotsDataTemplate'    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error 7: error C4430: missing type specifier - int assumed. Note: C++ does not support default-int  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error 8: error C2065: 'NpcBotsDataTemplate' : undeclared identifier C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error 9: error C2065: 'NpcBotsDataTemplate' : undeclared identifier C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3234
Error 10: error C2146: syntax error : missing ';' before identifier 'npcBotsData'   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3234
Error 11: error C2065: 'npcBotsData' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3234
Error 12: error C2065: 'npcBotsData' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3240
Error 13: error C2228: left of '.push_back' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3240
Error 14: error C2065: 'npcBotsData' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3245
Error 15: error C2228: left of '.begin' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3245
Error 16: error C2065: 'npcBotsData' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3251
Error 17: error C2228: left of '.end' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3251
Error 18: error C2065: 'npcBotsData' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3257
Error 19: error C2228: left of '.begin' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3257
Error 20: error C2065: 'secondCheck' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3268
Error 21: error C2065: 'secondCheck' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3270
Error 22: error C2065: 'npcBotsData' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3282
Error 23: error C2228: left of '.begin' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3282

# When leaving both [+] and [-] code (and the [+ and -]s) in but replacing all lines from 3229 to the end of the code snippet (also while using 64 bit compilers and libs. Finally got it working....) [Stopped at first errors]

Error   2   error C2018: unknown character '0x40'   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3229
Error   3   error C2144: syntax error : 'void' should be preceded by ';'    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3229
Error   4   error C2143: syntax error : missing ';' before '-'  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   5   error C2761: 'void Player::CreateNPCBot(uint8)' : member function redeclaration not allowed C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   6   error C2275: 'std::set<_Kty>' : illegal use of this type as an expression   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   7   error C2146: syntax error : missing ';' before identifier 'npcBotsData' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   8   error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   9   error C2059: syntax error : 'typedef '  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3234
Error   10  error C2065: 'NpcBotsDataTemplate' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3235
Error   11  error C2146: syntax error : missing ';' before identifier 'npcBotsData' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3235
Error   12  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3235
Error   13  error C2275: 'uint32' : illegal use of this type as an expression   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3240
Error   14  error C2146: syntax error : missing ';' before identifier 'temp_race'   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3240
Error   15  error C2065: 'temp_race' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3240
Error   16  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3241
Error   17  error C2228: left of '.insert' must have class/struct/union C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3241
Error   18  error C2065: 'temp_race' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3241
Error   19  error C2275: 'uint8' : illegal use of this type as an expression    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3242
Error   20  error C2146: syntax error : missing ';' before identifier 'temp_race'   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3242
Error   21  error C2065: 'temp_race' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3242
Error   22  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3243
Error   23  error C2228: left of '.push_back' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3243
Error   24  error C2065: 'temp_race' : undeclared identifier    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3243
Error   25  error C2275: 'std::set<_Kty>::const_iterator' : illegal use of this type as an expression   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3248
Error   26  error C2146: syntax error : missing ';' before identifier 'itr' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3248
Error   27  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3248
Error   28  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3248
Error   29  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3248
Error   30  error C2275: 'std::list<_Ty>::const_iterator' : illegal use of this type as an expression   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   31  error C2146: syntax error : missing ';' before identifier 'itr' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   32  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   33  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   34  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   35  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3255
Error   36  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3255
Error   37  error C2228: left of '.end' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3255
Error   38  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3258
Error   39  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3261
Error   40  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3261
Error   41  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3261
Error   42  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3268
Error   43  error C2228: left of '.first' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3268
Error   44  error C2065: 'secondCheck' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3272
Error   45  error C2065: 'secondCheck' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3274
Error   46  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3280
Error   47  error C2228: left of '.first' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3280
Error   48  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3281
Error   49  error C2228: left of '.second' must have class/struct/union C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3281
Error   50  error C2065: 'itr' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3286
Error   51  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3286

# When leaving both [+] and [-] code (but not the [+ and -]s, also removed @@ -3228,18 +3229,19 @@) in but replacing all lines from 3229 to the end of the code snippet (64 bit)

Error   2   error C2143: syntax error : missing ';' before 'std::set<_Kty>' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   3   error C2761: 'void Player::CreateNPCBot(uint8)' : member function redeclaration not allowed C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   4   error C2371: 'npcBotsData' : redefinition; different basic types    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3235
Error   5   error C2664: 'std::make_pair' : cannot convert parameter 1 from 'uint32' to 'uint32 &&' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3241
Error   6   error C2371: 'temp_race' : redefinition; different basic types  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3242
Error   7   error C2039: 'push_back' : is not a member of 'std::set<_Kty>'  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3243
Error   8   error C2371: 'itr' : redefinition; different basic types    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   9   error C2440: 'initializing' : cannot convert from 'std::_Tree_const_iterator<_Mytree>' to 'std::_List_const_iterator<_Mylist>'  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3249
Error   10  error C2088: '==' : illegal for class   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3255
Error   11  error C2088: '--' : illegal for class   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3258
Error   12  error C2088: '==' : illegal for class   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3261
Error   13  error C2100: illegal indirection    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3268
Error   14  error C2039: 'first' : is not a member of 'std::_Tree_const_iterator<_Mytree>'  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3268
Error   15  error C2065: 'secondCheck' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3272
Error   16  error C2065: 'secondCheck' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3274
Error   17  error C2100: illegal indirection    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3280
Error   18  error C2039: 'first' : is not a member of 'std::_Tree_const_iterator<_Mytree>'  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3280
Error   19  error C2100: illegal indirection    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3281
Error   20  error C2039: 'second' : is not a member of 'std::_Tree_const_iterator<_Mytree>' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3281
Error   21  error C2088: '--' : illegal for class   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3293
Error   22  error C2088: '++' : illegal for class   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3296

# When compiling in 64 bit and using the original patch. (Stopped at first error)

Error 2: error C2664: 'std::make_pair' : cannot convert parameter 1 from 'uint32' to 'uint32 &&' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp 3237

# When taking out the [-] code and replacing with [+] code. As well as removed "@@ -3228,18 +3229,19 @@" (64 bit) [Stopped at first errors]

Error   2   error C2144: syntax error : 'int' should be preceded by ';' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   3   error C2761: 'void Player::CreateNPCBot(uint8)' : member function redeclaration not allowed C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   4   error C2146: syntax error : missing ';' before identifier 'NpcBotsDataTemplate' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   5   error C4430: missing type specifier - int assumed. Note: C++ does not support default-int   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   6   error C2065: 'NpcBotsDataTemplate' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   7   error C2065: 'NpcBotsDataTemplate' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   8   error C2146: syntax error : missing ';' before identifier 'npcBotsData' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   9   error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   10  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3239
Error   11  error C2228: left of '.push_back' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3239
Error   12  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3244
Error   13  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3244
Error   14  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3251
Error   15  error C2228: left of '.end' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3251
Error   16  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3257
Error   17  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3257
Error   18  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3282
Error   19  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3282

# When taking out the [-] code and replacing with [+] code. (64 bit) [Stopeed at first errors]

Error   2   error C2018: unknown character '0x40'   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3229
Error   3   error C2144: syntax error : 'void' should be preceded by ';'    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3229
Error   4   error C2144: syntax error : 'int' should be preceded by ';' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   5   error C2761: 'void Player::CreateNPCBot(uint8)' : member function redeclaration not allowed C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   6   error C2146: syntax error : missing ';' before identifier 'NpcBotsDataTemplate' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   7   error C4430: missing type specifier - int assumed. Note: C++ does not support default-int   C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   8   error C2065: 'NpcBotsDataTemplate' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3232
Error   9   error C2065: 'NpcBotsDataTemplate' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   10  error C2146: syntax error : missing ';' before identifier 'npcBotsData' C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   11  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3233
Error   12  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3239
Error   13  error C2228: left of '.push_back' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3239
Error   14  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3244
Error   15  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3244
Error   16  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3251
Error   17  error C2228: left of '.end' must have class/struct/union    C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3251
Error   18  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3257
Error   19  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3257
Error   20  error C2065: 'npcBotsData' : undeclared identifier  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3282
Error   21  error C2228: left of '.begin' must have class/struct/union  C:\TrinityCore\src\server\game\Entities\Player\Player.cpp   3282

Just so you're aware, I've been editing the .cpp file with notepad++. I also always clean the solution beforehand.

I'm very new to all of this, if there is something in the patch process I am missing, PLEASE point it out. Otherwise I won't know I've done wrong.

[trickerer]

Alright, revert changes and apply this patch on top of the original patch.
Aslo you do not need to clean solution because you only need to fix compilation of 1 .cpp file

[Former user]

Rebuilding caused no errors and when using .npcb command worked! WOOT! Thanks a ton mang!

Anyway now I just need to learn it; do I have to program in the rotations or is that taken care of and then for battlegrounds do I have to program in their whole routine?

Also, is there a way to change a generic bot's armor and weapons? If not, how do I create an NPC bot of a player without the playerbot needing to be present? Sorta like a template I suppose.

Bur! I sorta figured though, what with you only getting back to me in the PM hours. :P

[trickerer]

Kek, greetings from other side of the Earth, dude. It's around 11AM here

[Former user]

HERE'S HOW IT WAS FIXED!

Freshly installed the Trinitycore source and MySQL Server 5.5 (as well as removing a ton of redundancies such as having MySQL 5.6 installed with 5.5.

Installed the whole BASE SYSTEM, INCLUDING BUILDING! As well as BEFORE CONFIGURING THE SERVER, but AFTER BUILDING, applied the patches. Starting with npcbots.patch and then to botfix.patch; EXACTLY IN THAT ORDER.

Set up the server and all that junk.

Started the server once as well as logged in.

REBUILT the solution. DID NOT CLEAN FIRST.

reconfigured the .conf auth and world files.

WORKED!

[Former user]

nvm, fixed it. Sorry....

[trickerer]

Ok, I'll include this into next commit then

[Former user]

is there a way to make playerbots act like npcbots? Like cast spells instead of just running up and attacking people?

[trickerer]

No, playerbots are under rewrite (and btw disabled by default by now). You can browse commits for more detail if you want.