- marked as minor
declaration/definition mismatch for deinit_liberasurecode_rs_vand
The declaration:
include/rs_vand/liberasurecode_rs_vand.h:void deinit_liberasurecode_rs_vand();
is missing parameters (int k, int m), but the definition is using them. what behavior is actually intended? my compile environment is complainaing aobut this mismatch.
I can send a pull request fixing it to be consistent, but I don't know in which direction it should be fixed (removing parameters everywhere since they're not used by the actual implementation, or adding them everywhere).
Comments (5)
-
reporter -
repo owner @dirk_m_ller thanks for the report. C-style function prototypes are flexible :) but I agree this needs to be fixed. Can you please add the k, m parameters to the prototype and submit a pull request.
CC: @kmgreen2
-
I think we can remove them from the function definition, as k and m are not used... Not sure how this got by us.
@dirk_m_ller Go ahead and submit the pull request! Thanks!
-
reporter I submitted two variants, please pick one that you like:
https://bitbucket.org/tsg-/liberasurecode/pull-requests/21/fix-prototype-declaration-definition/diff https://bitbucket.org/tsg-/liberasurecode/pull-requests/19/pass-down-parameters-to-all-occurences-of/diff
-
repo owner - changed status to resolved
Fixed in https://bitbucket.org/tsg-/liberasurecode/commits/92b7598bd3e916ea7e06b6c0c697d2b9fc280459.
Please close the other open pull request. Thank you!
- Log in to comment