declaration/definition mismatch for deinit_liberasurecode_rs_vand

Issue #25 resolved
Dirk Müller created an issue

The declaration:

include/rs_vand/liberasurecode_rs_vand.h:void deinit_liberasurecode_rs_vand();

is missing parameters (int k, int m), but the definition is using them. what behavior is actually intended? my compile environment is complainaing aobut this mismatch.

I can send a pull request fixing it to be consistent, but I don't know in which direction it should be fixed (removing parameters everywhere since they're not used by the actual implementation, or adding them everywhere).

Comments (5)

  1. Tushar Gohad repo owner

    @dirk_m_ller thanks for the report. C-style function prototypes are flexible :) but I agree this needs to be fixed. Can you please add the k, m parameters to the prototype and submit a pull request.

    CC: @kmgreen2

  2. Kevin Greenan

    I think we can remove them from the function definition, as k and m are not used... Not sure how this got by us.

    @dirk_m_ller Go ahead and submit the pull request! Thanks!

  3. Log in to comment