Crash (running out of nursery objects) since upgrading to 1.2.4
Issue #57
resolved
I'm experiencing crashes in my app with the 1.2.4 package. Sometimes they are nursery object crashes and other times it just dies.
I was able to fix the crash by reverting 55e887e (pull request #10). I don't know WHY that pull request is crashing my app (it looks sane but I can't seem to debug this) but it appears to be the case.
Comments (7)
-
-
reporter My guess is that we're recursing and blowing through the stack on the last line of
public static bool IsAssignableToGenericType(this TypeInfo givenType, TypeInfo genericType) { if(givenType == null || genericType == null) { return false; } return givenType == genericType || givenType.MapsToGenericTypeDefinition(genericType) || givenType.HasInterfaceThatMapsToGenericTypeDefinition(genericType) || givenType.IsAssignableToGenericType(genericType); }
-
That makes sense. It crashes only if none of the previous comparisons return
true
and works otherwise. -
Pull request reverted in nuget package 1.2.5, can you test if that works for you?
-
reporter It works!
-
Fixed it with pull request #12. The recursion was of course very unnecessary.
-
- changed status to resolved
- Log in to comment
Thanks for reporting, I'm going to revert that commit until we find out what happens.