1. Germano Gabbianelli
  2. django


ram...@bcc190cf-cafb-0310-a4f2-bffc1f526a37  committed d57e25e

Fiexed #3055 -- Validate that models target of a GenericRelation have a GenericForeignKey field.

Thanks jason for diagnosing the problem and Marcos Moyano for the patch.

  • Participants
  • Parent commits da478e3
  • Branches default

Comments (0)

Files changed (3)

File django/core/management/validation.py

View file
 import sys
+from django.contrib.contenttypes.generic import GenericForeignKey, GenericRelation
 from django.core.management.color import color_style
 from django.utils.itercompat import is_iterable
+    any
+except NameError:
+    from django.utils.itercompat import any
 class ModelErrorCollection:
     def __init__(self, outfile=sys.stdout):
         self.errors = []
                 e.add(opts, "'%s' specifies an m2m relation through model %s, "
                     "which has not been installed" % (f.name, f.rel.through)
+            elif isinstance(f, GenericRelation):
+                if not any([isinstance(vfield, GenericForeignKey) for vfield in f.rel.to._meta.virtual_fields]):
+                    e.add(opts, "Model '%s' must have a GenericForeignKey in "
+                        "order to create a GenericRelation that points to it."
+                        % f.rel.to.__name__
+                    )
             rel_opts = f.rel.to._meta
             rel_name = RelatedObject(f.rel.to, cls, f).get_accessor_name()

File django/utils/itercompat.py

View file
         if not item:
             return False
     return True
+def any(iterable):
+    for item in iterable:
+        if item:
+            return True
+    return False

File tests/modeltests/invalid_models/models.py

View file
 This example exists purely to point out errors in models.
+from django.contrib.contenttypes import generic
 from django.db import models
 class FieldErrors(models.Model):
 class InvalidSetDefault(models.Model):
     fk = models.ForeignKey('self', on_delete=models.SET_DEFAULT)
+class Tag(models.Model):
+   name = models.CharField("name", max_length=20)
+class TaggedObject(models.Model):
+   object_id = models.PositiveIntegerField("Object ID")
+   tag = models.ForeignKey(Tag)
+   content_object = generic.GenericForeignKey()
+class UserTaggedObject(models.Model):
+   object_tag = models.ForeignKey(TaggedObject)
+class ArticleAttachment(models.Model):
+   tags = generic.GenericRelation(TaggedObject)
+   user_tags = generic.GenericRelation(UserTaggedObject)
 model_errors = """invalid_models.fielderrors: "charfield": CharFields require a "max_length" attribute that is a positive integer.
 invalid_models.fielderrors: "charfield2": CharFields require a "max_length" attribute that is a positive integer.
 invalid_models.nonexistingorderingwithsingleunderscore: "ordering" refers to "does_not_exist", a field that doesn't exist.
 invalid_models.invalidsetnull: 'fk' specifies on_delete=SET_NULL, but cannot be null.
 invalid_models.invalidsetdefault: 'fk' specifies on_delete=SET_DEFAULT, but has no default value.
+invalid_models.articleattachment: Model 'UserTaggedObject' must have a GenericForeignKey in order to create a GenericRelation that points to it.