James Bennett avatar James Bennett committed ad134e2

Nuke the save() method of RegistrationForm, and add a note explaining why.

Comments (0)

Files changed (1)


     requires the password to be entered twice to catch typos.
     Subclasses should feel free to add any additional validation they
-    need, but should either preserve the base ``save()`` or implement
-    a ``save()`` method which returns a ``User``.
+    need, but should avoid defining a ``save()`` method -- the actual
+    saving of collected user data is delegated to the active
+    registration backend.
     username = forms.RegexField(regex=r'^\w+$',
             if self.cleaned_data['password1'] != self.cleaned_data['password2']:
                 raise forms.ValidationError(_(u'You must type the same password each time'))
         return self.cleaned_data
-    def save(self):
-        """
-        Create the new ``User`` and ``RegistrationProfile``, and
-        returns the ``User`` (by calling
-        ``RegistrationProfile.objects.create_inactive_user()``).
-        """
-        new_user = RegistrationProfile.objects.create_inactive_user(username=self.cleaned_data['username'],
-                                                                    password=self.cleaned_data['password1'],
-                                                                    email=self.cleaned_data['email'])
-        return new_user
 class RegistrationFormTermsOfService(RegistrationForm):
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.