Pull requests

#24 Declined
Repository
danielsokolowski danielsokolowski
Branch
default
Repository
ubernostrum ubernostrum
Branch
default

EMAIL_SUBJECT_PREFIX is now prefixed to the subject of activation email.

Author
  1. Daniel Sokolowski
Reviewers
Description

Useful for various reasons, but could also conflict for other; what are your thoughts?

  • Learn about pull requests

Comments (8)

  1. ndarville

    I wouldn’t expect to see this get merged, until you separate your other stylistic changes into a separate merge request. This merge request does more than what it claims to do.

  2. Daniel Sokolowski author

    Hi ndarville, super thanks for taking a look at it, I can re-submit without the auto styling changes - do you have perms to merge it in though as the original pull request was over a year ago with no signs of life from the author.

  3. Stephen Muss

    Stylistic changes aside, I don't think it is safe here to assume that EMAIL_SUBJECT_PREFIX has been specified in settings.

    It seems to me that the following would be a safer bet.

    subject = getattr(settings, 'EMAIL_SUBJECT_PREFIX', '') + render_to_string('registration/activation_email_subject.txt',
                                                                               ctx_dict)
    
  4. Daniel Sokolowski author

    Hello, could a justification be provided as to why this was declined ?

    Daniel Sokolowski Web Engineer Danols Web Engineering http://webdesign.danols.com/ Office: 613-817-6833 Fax: 613-817-5340 Toll Free: 1-855-5DANOLS Kingston, ON K7L 1H3, Canada

    Notice of Confidentiality: The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review re-transmission dissemination or other use of or taking of any action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you received this in error please contact the sender immediately by return electronic transmission and then immediately delete this transmission including all attachments without copying distributing or disclosing same.