#30 Declined
Repository
mrginglymus mrginglymus
Branch
default
Repository
ubernostrum ubernostrum
Branch
default

Django 1.5 compatibility with custom User models

Author
  1. Bill Collins avatarBill Collins
Reviewers
Description

Allows registration to work with custom user models (does not fix direct_to_template).

Comments (15)

    1. Alan Boyce

      I'm just curious as to what this means. You're not rejecting the patch because of it's contents, but because too many people hit the approve button?

      Should he resubmit and ask people not to hit the approve button?

    2. Bertrand Bordage

      So, what could we do to get Django 1.5 compatibility? The main new feature of 1.5 being the configurable User model, django-registration should have been one of the first packages to be compatible with it.

      I don't want to bother you, but acting like that is disrespectful for the nearly thousand followers of django-registration (one of the most followed django project!). If you don't want to manage this package anymore, give this responsability to someone else, but please, don't ruin it like this. No one wants to see a "django-registration3" fork as the future of "django-registration"…

      1. James Bennett repo owner

        Well, I've said multiple times that I'll be working on this during the PyCon sprints. So, you know, how about giving me a chance to do what I said I'd do? Because honestly, every time somebody ignores me saying that and starts spamming this thing again, I get more and more tempted to just move the repository off Bitbucket in order to cut off peoples' ability to abuse it.

        1. Ben Jeffrey

          With all due respect, if you honestly feel this way then perhaps it would be better that you take your repository offline, and let someone else maintain django-registration on PyPI.

          We all appreciate that you might not have much spare time, but consistently ignoring and refusing to accept working patches is hurting everyone's experience. There are already 365 forks of this repo, and a number of open pull-requests, all fixing this bug, but you control the PyPI package. I (and everyone else using custom user models) cannot use django-registration from pip without further research and work. Unless I fork the repo, I can't deploy a project using django-registration.

          Since you see all this volunteer work as "spam", perhaps it would be better to stop it at the source? Implement the fix and push a point-release? Please?

          You hold the keys to distributing a highly-regarded and useful open-source project and, like it or not, that does carry responsibilities to maintain it in a timely manner, and not to alienate the people who use it.

  1. migajek

    well, django 1.5 is right behind the corner. Is that the way you "solve" the compatibility problem? Please leave the pull request at least so the users can find it easy and patch themselves.

  2. Jacky Alciné

    It's simple, guys. Apply the patch and keep moving. Since the concept of open development doesn't seem to apply here, it's best if we just mitiage the traffic here.

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.