Move statistics js code to udemi.js

Issue #104 resolved
Enrico Piccini created an issue

I saw in udemi.js that the statistics section is empty and there's a comment "//David move statistics JS code here please"

Comments (7)

  1. David Marrs

    I've made a start on this tonight, but I think I'll need @enricosoft to review it before it gets merged into the develop branch

  2. David Marrs

    @enricosoft I have now commited changes on the new branch feature/refactor-stats. Please take a look and let me know if it is arranged in the way you would expect and if it is ok I will merge it into the develop branch.

    I wonder if now that I have done this we don't need the onDataLoaded callback? I seem to remember that I made a special request for that to be added so that I could get the pie charts to work the first way round.

  3. Enrico Piccini reporter

    Hey David, it's ok! if I remember well, I named the "private" functions like "_name" and the public functions like "name"... so if init and set are public if you want you can rename them... About the "onDataLoaded" callback I created it for general purpose, so in case of necessity anyone can use it... I think we can mantain this :)

  4. Log in to comment