Mario Update 3: Have the Issues Policies Actions Tabs as main menue in every single page of UDEMI

[udemi]

As discussed over the phone, lets have the issues policies actions tabs in every main page. Only difference between home page and all other pages is:

Only on the Home Page (where there is the map) we have the Search and Share box right of the tabs, on all the other pages (profile, issue detail page etc) the search and share box is not there.

[Enrico Piccini]

At first glance I said it's not a problem... but I think we should evaluate if it's really not a problem because I'm not sure from the technical side and from the navigation side. The point is to improve our current navigation that has some problems, and I agree to do that

[Enrico Piccini]

@dwmarrs Dave wait to do this because Mario and Rob are talking about it because this one is not the best solution for all pages. Ask to Rob before do this

[udemi]

OK @dwmarrs and @enricosoft - Mario has decided we do it as suggested: the main navigation (concerns - solutions - actions - users) will appear on ALL sites :)

[David Marrs]

Done on development branch

[Enrico Piccini]

Hey Dave, good job! I have only 2 things to report to you:

• The menu items must be active only if the user is on a stance list page or user profiles page. (see attachment "menu-bug.jpg")

• On the stance form page the menu is not well aligned (see attachment "menu-bug-2.jpg")

Solved these, it's ok :)

[David Marrs]

But that was intentional... you're dealing with a user or a policy so the menu should reflect that no?

[Enrico Piccini]

Hi Dave, those links link to specific pages so I think it's not correct to maintain the active state... if in the header they were a section with a submenu, in that case yes it was correct. So I think they should be active only when you're seeing that specific page... What do you think?

[udemi]

Hey guys,

Enrico is right, the active state only refers to the specific 4 pages from home page :)

Great job David!

Rob

[David Marrs]

@enricosoft I dunno, I think lighting up the links will help to steer the user as to what they're looking at. It's pretty easy for me to undo though. I just need to remove the ng-init and ng-controller attributes from each of the relevant divs with a ng-include="'/static/templates/sub_nav.html'" attribute.

Before I do that @udemi can you ask Mario's opinion? Thanks.

[Enrico Piccini]

@dwmarrs Hi Dave, I think you can proceed with the undo so we can close this task and deploy to test... We will reason better about it in the final version of Udemi :)

[David Marrs]

@enricosoft I've removed the highlighting on commit 5456c21 so you can deploy to the test site. We can always revert it if we want to bring the highlighting back.