Opt in opt out does not work on home page

David Marrs

changed status to resolved

I think it's a hangover from when the thumbs up/down where anchor tags rather than form tags. The problem was around line 43 of templates/issues/partials/issue_detail.html. There was a click event handler which was grabbing the anchor tag and firing an ajax POST request. The new form tags have the same class as the old anchor tags, so they weren't being submitted on click. The reason the POST was going to the root of the site was because the click event handler was taking the url to use from the href attribute of the clicked tag, and form tags don't have a href attribute (they have an action attribute).

For now, in the interests of just getting something working, I have removed the click event handler so that the forms just submit (and the user is taken to the relevant issue page). Otherwise, we need to get some JSON response in place to indicate success/failure and handle updating the opt ins/outs and ratio on the client side.

Would be good if we could get some kind of message to show that the vote has been counted though?

2013-06-08T14:49:02+00:00

Comments (3)

André Palma
The form its there but for some reason when we click on any thumbs up/thumbs down there is a post request made to the root of the web-site.

I did try to trace through the javascript but with no success.
- 2013-06-05T00:11:28+00:00
David Marrs
I think I have found the relevant JavaScript: will write up my findings/make necessary commits after some lunch...
- 2013-06-08T13:19:10+00:00
David Marrs
- changed status to resolved
I think it's a hangover from when the thumbs up/down where anchor tags rather than form tags. The problem was around line 43 of templates/issues/partials/issue_detail.html. There was a click event handler which was grabbing the anchor tag and firing an ajax POST request. The new form tags have the same class as the old anchor tags, so they weren't being submitted on click. The reason the POST was going to the root of the site was because the click event handler was taking the url to use from the href attribute of the clicked tag, and form tags don't have a href attribute (they have an action attribute).

For now, in the interests of just getting something working, I have removed the click event handler so that the forms just submit (and the user is taken to the relevant issue page). Otherwise, we need to get some JSON response in place to indicate success/failure and handle updating the opt ins/outs and ratio on the client side.

Would be good if we could get some kind of message to show that the vote has been counted though?
- 2013-06-08T14:49:02+00:00
Log in to comment