Error handling

[Igor Serikov]

Terminating JVM in”resize” (jdd/bdd/NodeTable.java) causes problems in production environment.

Suggestion: the exception should be re-thrown (or not handled at all), so the production application can log a proper message of its own.

[Arash Vahidi (private)]

I can move the exit code to its own function which you can override if you want a different behavior.

Note however that the JVM normally terminates after a OutOfMemoryError, hence the error handling code is never reached.

[Igor Serikov]

Yes, moving the termination into a function that I can override would work. Just pass the exception to it so I can re-throw it.

Adding a configuration option preventing termination would work too.

[Arash Vahidi (private)]

See if commit 50442a1 solves your problem.

‌

It is a fairly large commit, but changes related to this issue are all in NodeTable

‌

https://bitbucket.org/vahidi/jdd/commits/50442a173a50746d36cb9f8830137db81cc85b72#chg-src/jdd/bdd/NodeTable.java

[Igor Serikov]

Is it possible to rename “fatal” to outOfMemoryHandler?

Then all I need to do is:

@Override
public void outOfmemoryHandler(String message) {
  throw new OutOfMoeoryError(message);
}

This way I retain the exception name as well known OutOfMemoryError and use your message to provide an additional information.

[Arash Vahidi (private)]

I don’t think that is a good idea, fatal() can be called for other reasons too.

[Igor Serikov]

That is exactly the problem that I am trying to solve. I think, it is better to have an error class. Can we do the following?

Your code:

public void outOfmemoryErrorHandler(String message) {
  fatal(message);
}
public void fatal(String message) {
...
}

You might call “fatal()” directly for some “uncategorized” errors.

My Code:

@Override
public void outOfmemoryHandler(String message) {
  throw new OutOfMemoryError("JDD: " + message);
}
@Override
public void fatal(String message) {
// An uncategorized JDD error
  throw new RuntimeException("JDD: " + message);
}

[Igor Serikov]

Or, if you think that what I proposed is excessive, just re-define your “fatal” as

public void fatal(Exception exc, String message)

and supply an exception when appropriate.

My problem is that OutOfMemoryError is a distinct type of error and needs to be shown as such in the logs.

[Arash Vahidi (private)]

Lets try this one instead:

public void fatal(Error e, String message)

‌

see commit e82e13d

[Arash Vahidi (private)]

fixed in 111