nuget: packages.config not correctly parsed

[Jens Doose]

The packages.config is not correctly parsed. See the following packages.config and the parsing result on the VersionEye website.

Project created by "create by upload"

<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="BuildTools.StyleCop" version="4.7.49.0" targetFramework="net40" />
  <package id="CsQuery" version="1.3.4" targetFramework="net40" />
  <package id="Microsoft.AspNet.Razor" version="2.0.30506.0" targetFramework="net40" />
  <package id="Onwerk.Mailer" version="1.6.6.0" targetFramework="net40" />
  <package id="PreMailer.Net" version="1.2.9" targetFramework="net40" />
  <package id="RazorEngine" version="3.7.7" targetFramework="net40" />
  <package id="Simple.Data.Ado" version="0.18.3.1" targetFramework="net40" />
  <package id="Simple.Data.Core" version="0.18.3.1" targetFramework="net40" />
  <package id="Simple.Data.SqlServer" version="0.18.3.1" targetFramework="net40" />
  <package id="SlowCheetah" version="2.5.12" targetFramework="net40" />
</packages>

[Robert Reiz]

Hi @jdoose thank your for your feedback. We check it out. If you have time can you post a link to the project? If it is public ;-)

[Timo Sulg]

Seems that's an issue with parsing version-numbers that aren't proper Semver as Nuget spec defines here: https://docs.nuget.org/create/versioning#Specifying-Version-Ranges-in-.nuspec-Files

It shouldn't be difficult to fix;

[Jens Doose]

Unfortunately it is not public - of course. I bet you knew it before ;) @timgluz , great to hear!

[Timo Sulg]

I submitted PR with my fix and tests; this parsing error should be fixed now;

But i see another possible bug - CSQuery(2nd line) is marked outdated, but 1.3.5-beta5 is not stable release and therefore it shouldnt be marked as outdated. Is that right, @reiz ?

[Robert Reiz]

No. That line should be green as the used version is newer than what we have in our db.

[Robert Reiz]

I just merged the pull request. Tests are running right now.

[Robert Reiz]

@timgluz Tests are all green. I just deployed to production. @jdoose Can you please test again and confirm that it works like expected?

[Jens Doose]

Sorry to inform you guys that the result is still as it was before... I attached the file for your convenience with the test.

[Robert Reiz]

It's fixed now. See here: https://www.versioneye.com/user/projects/579b0894aa12250011aca954#tab-dependencies

[Jens Doose]

Ok, now that was magic... I swear it was still showing the error on Saturday... ;)

[Timo Sulg]

Hi, @jdoose

Correct me if i'm wrong, that all the versions in a packages.config are resolved by Nuget as x >= 1.0.0 and not x == 1.0.0.

I followed the "Constraining Upgrades To Allowed Versions" of the Nuget documentation: https://docs.nuget.org/create/versioning It sounds too strange - it's difficult to get repeatable builds that way.

I'm currently working on support for the `allowedVersions.

[Robert Reiz]

@jdoose I believe you. We updated the parser and I re uploaded your project file this morning ;-)

[Jens Doose]

@timgluz I assume that nuget always specifies the exact version but, to be honest, i never double-checked ;)