- script_id=787: I've sent an email to the author. We should wait a couple of days for a reply. Maybe we can move the code to github and implement the missing feature.
- vimproc: https://github.com/Shougo/vimproc.vim/issues/61
Support post-install hooks
Issue #62
resolved
Several plugins need some "special action" to complete the installation properly. It can be very different things: - install dependencies on other plugins (already tracked by VAM-kr) - fix bad plugin structure; e.g.: https://github.com/now/vim-info - run a program provided by the plugin; e.g.: http://www.vim.org/scripts/script.php?script_id=787 - run an external program; e.g.: https://github.com/Shougo/vimproc
At the moment, VAM-kr does not keep track when a manual action is needed, thus VAM does not warn the user. This breaks the principle of least surprise: if a plugin installs successfully, without even a warning, it is expected to work right away.
It would be great if VAM could at least warn the user that some action is required, and point to the relevant web page (or help topic, when available). Even better, if the exact command to run was recorded in VAM-kr, VAM could try to run it at install time (and only report in case of failure).
Comments (16)
-
-
I don't want "VAM" to do what plugins should do. I'd prefer making authors aware that they can improve their plugins rather than start maintaining many hooks. If there is no other way we can make VAM do it. However I'd rather fork and move the code on github.
-
Account Deleted
So you mean that educating plugin authors and forking plugins is an easier job than adding a few hooks? :)
-
Wondering who will be maintaining these hooks. I add them once for some plugins, but they are no longer maintained because I do not use these plugins. Thus somebody either needs to write automated tests for each of the plugins that will fail in case something changed (I am very unsure this is possible) or reread each plugin description to find out changes. There are some tricks to make job much easier possible, but I currently have no time to write even them, not to mention rereading.
Thus author-side support for installation/update hooks is better decision. I could not say forking is the good idea at all though.
26.06.13, 01:09, "Olivier Teulière" notifications@github.com":
So you mean that educating plugin authors and forking plugins is an easier job than adding a few hooks? :) — Reply to this email directly or view it on GitHub.
-
Account Deleted
Do you have tests to make sure that the plugin dependencies are correct (i.e. complete, and not superfluous)? If not, why would you need that for hooks and not for dependencies?
-
I did not say I do not need this for dependencies.
26.06.13, 01:33, "Olivier Teulière" notifications@github.com":
Do you have tests to make sure that the plugin dependencies are correct (i.e. complete, and not superfluous)? If not, why would you need that for hooks and not for dependencies? — Reply to this email directly or view it on GitHub.
-
Account Deleted
OK, I misunderstood you then. It looked like finding a solution for automated tests was a pre-requisite for having hooks ("Thus somebody needs to..."). I'm glad that it isn't the case.
-
-
@ ipkiss42 what are you using vimproc for exactly and on which operating system - just being curious
-
Account Deleted
Vimproc is used by various plugins such as unite and vimfiler. I use Windows and Linux.
-
@ipkiss42: Can you comment again what you mean exactly by "bad plugin structure" (vim-info) ? The author of "?script_id=787" did not reply. Should we clone and add the code running the hook to the repository?
-
Account Deleted
When you call the :Info command twice, you get an error because "now#vim#mark#cursor()' is called, which I assumed came from a bad layout (no autoload/ directory). But after all, it may very well be a bug in the plugin itself (I don't use it myself).
-
- run a program provided by the plugin; e.g.: http://www.vim.org/scripts/script.php?script_id=787
This topic is left. How to move on? Create a github repository and fix? The author didn't reply. Do you still use it?
re vim-info: Please don't make me care about packages you don't use in the future.
-
Account Deleted
No, I don't use this one anymore either.
Whether or not I use these packages is irrelevant. The point is that some packages exist out there with manual installation steps required. VAM could easily warn about that, but it doesn't.
-
It is relevant. We don't want to spend time on packages which are not used. Its natural that some plugins get outdated. There are 5000 packages. We cannot maintain them unless there is true interest. Our resources are limited. Closing this because all issues which affect you mentioned in this bug should be resolved then.
-
- changed status to resolved
- Log in to comment
