Pull requests

#4 Open
Repository
GDmac GDmac
Branch
default
Repository
wanwizard wanwizard
Branch
default

CI 3 compatibility: Active_record => Query_builder and fix property access

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/GDmac/datamapper
hg merge b2b8cb5edcf7
hg commit -m 'Merged in GDmac/datamapper (pull request #4)'
Author
  1. GDmac
Reviewers
Description

Had to make more use of dm_get and dm_set for qb_select et all. because most Query_builder properties are now protected (joy)

edit: this could probably better go into a datamapper_ci3 branch ?

Comments (1)

  1. Harro Verton repo owner

    This will indeed break DM on CI < v3, so it can't go in like this.

    I would prefer not to have multiple branches/versions, so we'll have to think about how to make it compatible for CI 2+, including 3.