Pull requests

#9 Merged
Repository
xt_rajesh xt_rajesh
Branch
default
Repository
webvariants webvariants
Branch
default

Implementation of SMTP based e-mail validator [elance]

Author
  1. Rajesh Bansal
Reviewers
Description

I have implemented the changes in the repository for SMTP Email validator. Please check and verify the changes.

Comments (4)

  1. Christoph Mewes

    Please make sure to follow our coding guidelines. There need to be spaces after control keywords (if (foo) { instead of if(foo){). Other than that, nice work :-)

    Please add your class to the repository's static.yml as smtp_mail in the validators section.

  2. Christoph Mewes

    Please change the indentation for else blocks to look like

    if (foo) {
    }
    else {
    }
    

    and make sure (and that's the last thing I have to complain about) that there are spaces around all equal signs ($a = 1 instead of $a=1).

  3. Christoph Mewes

    Rajesh, you mentioned that there are issues with this validator on hotmail and yahoo. Please provide links to the sources where you read about the problems, so we can verify and Dave can decide what to do.