1. Wez Furlong
  2. mtrack
  3. Issues
Issue #17 new

Code reviewing

Wez Furlong
repo owner created an issue

The intent of this feature is to formalize the code review process, but to do so without being overly intrusive (unless desired).

User stories:

As a code contributor, I'd like to request that other folks on the team review a set of changes because they are in an area of code with which I am not very familiar. In initiating the review, I want to have a description field where I can put my initial thoughts/comments about the review.

As a team lead, I'd like the system to automatically create a code review for members of my team, especially juniors. As part of this configuration, I'd like to optionally assign a default set of reviewers.

As a release manager, I'd like to be able to see which changes to a configurable area of the repo have or have not been reviewed so that I can decide if the release is blocked. I'd also like to see which reviewers are blocking the process.

As a release manager, I'd like the system to automatically create a code review for changes to configurable areas of the repo. These reviews will have a configurable due date.

As a reviewer, I'd like to see which reviews are awaiting my attention, along with due date and priority.

As a reviewer, I'd like to see the change sets in the review and have the ability to view them as diffs or the affected files.

As a reviewer, I'd like to comment on lines in the diff or source files.

As a reviewer, I'd like to "sign off" on the review. This should be tracked independently from a comment that I make on the review, but it should be convenient to sign-off as part of the commenting process.

As a code contributor, I'd like to create a code review from one or more uncommitted patch files so that they can be reviewed before they are applied to the repo.

As a code contributor or reviewer, I'd like to see code reviews that are associated with a ticket when I'm viewing the ticket.

As a reviewer, I'd like to pull in additional change sets or files from the repo, or add an uncommitted patch file to an existing review. I'd like to do this both from within the review itself, and also from the source/changeset browser via an "add to review / create review" button or menu option.

Comments (0)

  1. Log in to comment