Missing release branches
Hi Everyone,
We are trying the Wisky skin. It looks like a handsome skin. Thanks for providing it.
We noticed... Wisky is missing release branches. Over time, as Wisky grows older, it will be used on more and more Wiki platforms with different versions. For example, right now, there are 1.34, 1.35 (LTS) and 1.36. Some versions will be incompatible with one another. For example, calling BaseTemplate::getFooterIcons is OK in MW 1.35, but it generates a warning in MW 1.36.
To overcome the incompatibility, skin authors typically setup branches for a version. The branches are named REL1_35, REL1_36, etc. Then improvements and bug fixes are ported into the branch if needed. For example, BaseTemplate::getFooterIcons is avoided in MW 1.36 and above. MW 1.36.
Here is what our update script looks like. We run Mediawiki 1.36, so we checkout the REL1_36 branch. Notice Wisky is missing the REL1_36 branch:
```
~/update-wiki.sh
... Updating skin DarkVector Entering /var/www/html/w/skins/DarkVector REL1_36 branch not found HEAD is now at 690fea9 BaseTemplate::getFooterIcons was deprecated in MediaWiki 1.35. This commit replaces it with equivalent code. Branch master Updating skin Dusk Entering /var/www/html/w/skins/Dusk REL1_36 branch found HEAD is now at 4b40023 build: Updating path-parse to 1.0.7 Branch REL1_36 Updating skin wisky Entering /var/www/html/w/skins/wisky REL1_36 branch not found HEAD is now at d77d671 back to CSS: suggestions not fixed Branch master Updating skin Timeless Entering /var/www/html/w/skins/Timeless REL1_36 branch found HEAD is now at 6a2b487 build: Updating path-parse to 1.0.7 Branch REL1_36 Updating skin Modern Entering /var/www/html/w/skins/Modern REL1_36 branch found HEAD is now at 92d32d6 build: Updating path-parse to 1.0.7 Branch REL1_36 ... ...
Comments (0)
