Multiple non-unique IDs on archive pages
On the archive pages for the custom post type (wpfc_sermons) the featured image of the sermon displayed for each sermon. However, each image uses the same ID which isn't html standards compliant: http://www.w3.org/TR/html401/struct/global.html#h-7.5.2
Comments (6)
-
reporter -
reporter When it is not standards compliant to makes it difficult to create a theme that styles these elements. If you change those in the future to become more standards compliant, my styles will be lost. But I have no other way to reference them at the present.
-
reporter Also, on a related Wp standards note, I'm not sure what you think about this - but really, featured images should be handled by the theme - rather than the plugin. Featured images are not a feature controlled or created by the plugin - but rather, is a Wordpress function. Featured images themselves are not automatically pushed out except for where the theme calls it to be displayed.
So if you could, I would remove the featured image from archive and single pages altogether and let the theme pull the image out.
Many themes pull the featured image out (ie: twentytwelve) and this results in the image being displayed twice for each sermon.
-
repo owner I adjusted the ids for classes here: https://bitbucket.org/wpforchurch/sermon-manager-for-wordpress/commits/2f1b1b8edc3628935c91984eb59ce6b891812dbf
There's more cleanup that could be done on those I'm sure.
If you don't want the featured image displayed, just hide it with CSS:
.wpfc_sermon_image {display:none;}
I'll keep it in, because many sermons won't have an individual image, but they will have a speaker or series image.
-
repo owner - changed status to resolved
-
reporter Cool :)
- Log in to comment
For example this ID
#wpfc_sermon_wrap