sermon_sort_fields shortcode bug

[Allen Cox]

When processing most shortcodes you construct an HTML string and return that. Presumably the intent is to append the shortcode to the end of the page's content while it it being built.

However, when using the sermon_sort_fields shortcode, you do the following:

$sorting = render_wpfc_sorting(); return $sorting;

The render function does not return a string, but instead prints out the HTML immediately. The result of this is that sort_fields are always printed as the first div in a page's content block, which breaks intended layout and also breaks certain themes (e.g. we use GeneratePress, which stores content in page 'sections'. The sort fields end up appearing before the first page section).

[this bug report provided by David Nolan by email [e-mail]]

[Allen Cox]

David was also the one that gave specific details how to incorporate S3 auth into our plugin so that we can really leverage those services. I trust his judgement.

[James Hammack]

Resolved with 2.0