WIP: Client Side Migration

#656 Merged at 26367f1
Repository
funnelferry
Branch
GSOC2019-funnelferry
Repository
wxmetvis
Branch
GSOC2019-funnelferry
Author
  1. Anveshan Lal
Reviewers
Description
No description

Comments (2)

  1. Joern Ungermann

    Cool,

    it really works!
    Here some errors I got from testing more functionality. Most are probably easy to fix now.

    After changing some colors in Options dialogue:

    CRITICAL: Fatal error: Traceback (most recent call last):
      File "/home/icg173/src/mss/mslib/msui/topview.py", line 297, in settings_dialogue
        self.getView().set_map_appearance(settings)
      File "/home/icg173/src/mss/mslib/msui/mpl_qtwidget.py", line 1150, in set_map_appearance
        self.map.set_graticule_visible(settings["draw_graticule"])
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 219, in set_graticule_visible
        if visible and self.map_parallels is None and self.map_meridians is None:
    AttributeError: 'MapCanvas' object has no attribute 'map_parallels'
    

    Remotesensing widget (via the “(select to open control button)”):

      File "/home/icg173/src/mss/mslib/msui/remotesensing_dockwidget.py", line 130, in update_settings
        self.view.set_remote_sensing_appearance(settings)
      File "/home/icg173/src/mss/mslib/msui/mpl_qtwidget.py", line 1167, in set_remote_sensing_appearance
        self.waypoints_interactor.redraw_path()
      File "/home/icg173/src/mss/mslib/msui/mpl_pathinteractor.py", line 1068, in redraw_path
        self.map, wp_vertices, wp_heights)
      File "/home/icg173/src/mss/mslib/msui/remotesensing_dockwidget.py", line 157, in compute_tangent_lines
        wp_xy = ccrs.PlateCarree().transform_points(bmap.ax.projection, x, y)
    TypeError: Argument 'x' has incorrect type (expected numpy.ndarray, got tuple)
    

    and

      File "/home/icg173/src/mss/mslib/msui/remotesensing_dockwidget.py", line 130, in update_settings
        self.view.set_remote_sensing_appearance(settings)
      File "/home/icg173/src/mss/mslib/msui/mpl_qtwidget.py", line 1167, in set_remote_sensing_appearance
        self.waypoints_interactor.redraw_path()
      File "/home/icg173/src/mss/mslib/msui/mpl_pathinteractor.py", line 1078, in redraw_path
        self.map, wp_vertices, wp_heights, wp_times, self.show_solar_angle)
      File "/home/icg173/src/mss/mslib/msui/remotesensing_dockwidget.py", line 199, in compute_solar_lines
        wp_xy = ccrs.PlateCarree().transform_points(bmap.ax.projection, x, y)
    TypeError: Argument 'x' has incorrect type (expected numpy.ndarray, got tuple)
    

    Web Map Service widget (also via the “(select to open control button)”; enter “https://forecast.fz-juelich.de/demo” for the “WMS URL”, push first the “get capabilities” button and then the “retrieve” button in a projection that shows Europe):

    CRITICAL: Fatal error: Traceback (most recent call last):
      File "/home/icg173/src/mss/mslib/msui/wms_control.py", line 1653, in get_map
        bbox = self.view.getBBOX()
      File "/home/icg173/src/mss/mslib/msui/mpl_qtwidget.py", line 1021, in getBBOX
        axis0, axis2 = self.map(axis[0], axis[2], inverse=True)
    TypeError: 'MapCanvas' object is not callable
    

    KML Widget (also via the “(select to open control button)”; Push the “…” button and select the file at “docs/samples/kml/folder.kml” in the mss folder, then push load:

      File "/home/icg173/src/mss/mslib/msui/kmloverlay_dockwidget.py", line 141, in load_file
        self.cbManualStyle.isChecked(), self.get_color(), self.dsbLineWidth.value())
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 806, in __init__
        self.draw()
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 906, in draw
        self.parse_placemarks(self.kml.Document)
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 872, in parse_placemarks
        self.parse_placemarks(folder)
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 868, in parse_placemarks
        self.parse_geometries(placemark, style, name)
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 861, in parse_geometries
        method(attr, style, name)
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 822, in add_polygon
        x, y = self.compute_xy(getattr(polygon, boundary).LinearRing.coordinates)
      File "/home/icg173/src/mss/mslib/msui/mpl_map.py", line 811, in compute_xy
        return self.map(lons, lats)
    TypeError: 'MapCanvas' object is not callable
    

    What is quite a bit stranger is that I have troubles moving and deleting points after changing the projection. Insertion still works, but I cannot move or delete. After changing the projection back, all three functionalities work again.