flighttrack.py needs modification in save_to_mscolab function.
Just added another commit. I did the change and forgot to push it, apologies.
Let’s try to implement the following thing
making the directory when the user logs in
deleting the directory when the user logs out
since authentication expires after a certain duration, every time mss restarts, let’s run a function to check directories made ‘a day’ earlier and delete them.
We are doing this to prevent other users from seeing original user’s files. Unless we bind UNIX permissions into this, the above is one way to start with.
Since they are temporary files, we have the liberty to delete them, we can just fetch them from server whenever required. One of GSoC projects involves offline development for mscolab, where we have to store files for longer times then. We have to bind some sort of security to prevent viewing these ‘offline’ files.
Sounds good, @Prayas Jain ?
Yes, it is a good approach to implementing security, currently the user logs out automatically when the application closes. I guess, @Vaibhav Mehra and I could look into that issue before I implement the deletion part.
Yes, We could work on this. Maybe from next week.
Note that we aren’t using /tmp directory because, the ‘delete’ functionality is temporary. We have to secure this using encryption, when /filedata isn’t temporary storage anymore.
you can run for principal pep8 check on your changes
pytest --pep8 -k flight
pytest --pep8 -k mscolab
We do take care for pep8 because readabilty counts often that is looked up if one selects a project.