Commits

steveb  committed aa1e781

reporter.el-1.08

  • Participants
  • Parent commits c68d559

Comments (0)

Files changed (3)

+Thu Mar 19 12:24:19 1998  Barry A. Warsaw  <bwarsaw@cnri.reston.va.us>
+
+	* reporter.el:  Released 3.34 to RMS and SLB.
+
+Thu Mar 19 17:22:21 1998  Barry A. Warsaw  <bwarsaw@cnri.reston.va.us>
+
+	* reporter.el (mail-user-agent): Removed all mail-user-agent
+	related definitions since these are now part of X/Emacs.
+
+	* reporter.el (reporter-beautify-list): Break infloop when
+	reaching the end of the buffer without crossing an unbalanced
+	paren.  Use scan-sexps instead of forward-sexp for the loop break
+	test.
+
+Mon Jan 13 17:10:24 1997  Barry A. Warsaw  <bwarsaw@cnri.reston.va.us>
+
+	* reporter.el (reporter-submit-bug-report): Only call
+	display-buffer if pop-up-windows is non-nil.
+
+Thu Jan  9 23:04:46 1997  Barry A. Warsaw  <bwarsaw@cnri.reston.va.us>
+
+	* reporter.el: Merged in RMS changes from 29-Aug-1996.
+
 1998-02-24  SL Baur  <steve@altair.xemacs.org>
 
 	* rmail-mini.el: Define rmail-mode-map.
 
 # This XEmacs package contains independent single file lisp packages
 
-VERSION = 1.07
+VERSION = 1.08
 AUTHOR_VERSION =
 MAINTAINER = XEmacs Development Team <xemacs-beta@xemacs.org>
 PACKAGE = mail-lib
 ;;; reporter.el --- customizable bug reporting of lisp programs
 
-;; Copyright (C) 1993 1994 1995 1996 Free Software Foundation, Inc.
+;; Copyright (C) 1993,1994,1995,1996,1997,1998 Free Software Foundation, Inc.
 
-;; Author:          1993-1996 Barry A. Warsaw
+;; Author:          1993-1998 Barry A. Warsaw
+;; Maintainer:      tools-help@python.org
 ;; Created:         19-Apr-1993
-;; Version:         3.3
-;; Last Modified:   1996/07/02 00:39:09
+;; Version:         3.34
+;; Last Modified:   1998/03/19 17:21:16
 ;; Keywords: maint mail tools
 
-;; This file is part of XEmacs.
+;; This file is part of GNU Emacs.
 
-;; XEmacs is free software; you can redistribute it and/or modify
+;; GNU Emacs is free software; you can redistribute it and/or modify
 ;; it under the terms of the GNU General Public License as published by
 ;; the Free Software Foundation; either version 2, or (at your option)
 ;; any later version.
 
-;; XEmacs is distributed in the hope that it will be useful,
+;; GNU Emacs is distributed in the hope that it will be useful,
 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 ;; GNU General Public License for more details.
 
 ;; You should have received a copy of the GNU General Public License
-;; along with XEmacs; see the file COPYING.  If not, write to the
+;; along with GNU Emacs; see the file COPYING.  If not, write to the
 ;; Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 ;; Boston, MA 02111-1307, USA.
 
-;;; Synched up with: FSF 19.34.
-
 ;;; Commentary:
 
 ;; End User Interface
 ;; ==================
 ;; The variable `mail-user-agent' contains a symbol indicating which
 ;; Emacs mail package end users would like to use to compose outgoing
-;; mail.  See that variable for details.
-
-;; Mail Package Interface
-;; ======================
-;; Mail package authors can configure reporter to support their
-;; package by calling the function `define-mail-user-agent' See that
-;; function for details.
+;; mail.  See that variable for details (it is no longer defined in
+;; this file).
 
 ;; Lisp Package Authors
 ;; ====================
-;; Reporter was written primarily for Emacs Lisp package authors so
-;; that their users can easily report bugs.  When invoked,
-;; reporter-submit-bug-report will set up an outgoing mail buffer with
-;; the appropriate bug report address, including a lisp expression the
-;; maintainer of the package can eval to completely reproduce the
-;; environment in which the bug was observed (e.g. by using
-;; eval-last-sexp).  This package proved especially useful during my
-;; development of cc-mode, which is highly dependent on its
+;; reporter.el was written primarily for Emacs Lisp package authors so
+;; that their users can more easily report bugs.  When invoked,
+;; `reporter-submit-bug-report' will set up an outgoing mail buffer
+;; with the appropriate bug report address, including a lisp
+;; expression the maintainer of the package can evaluate to completely
+;; reproduce the environment in which the bug was observed (e.g. by
+;; using `eval-last-sexp').  This package proved especially useful
+;; during my development of CC Mode, which is highly dependent on its
 ;; configuration variables.
 ;;
 ;; Do a "C-h f reporter-submit-bug-report" for more information.
 ;;(defun mypkg-submit-bug-report ()
 ;;  "Submit via mail a bug report on mypkg"
 ;;  (interactive)
+;;  (require 'reporter)
 ;;  (reporter-submit-bug-report
 ;;   mypkg-maintainer-address
 ;;   (concat "mypkg.el " mypkg-version)
 ;;         ;; ...
 ;;         'mypkg-variable-last)))
 
-;; Mailing List
-;; ============
-;; I've set up a Majordomo mailing list to report bugs or suggest
-;; enhancements, etc.  This list's intended audience is elisp package
-;; authors who are using reporter and want to stay current with
-;; releases. Here are the relevant addresses:
-;;
-;; Administrivia: reporter-request@python.org
-;; Submissions:   reporter@python.org
-
-;; Packages that currently use reporter are: cc-mode, supercite, elp,
+;; Reporter Users
+;; ==============
+;; Packages that currently use reporter are: CC Mode, supercite, elp,
 ;; tcl, ediff, crypt++ (crypt), dired-x, rmailgen, mode-line, vm,
 ;; mh-e, edebug, archie, viper, w3-mode, framepop, hl319, hilit19,
-;; pgp, eos, hm--html, efs.
+;; pgp, eos, hm--html, efs, webster19.
 ;;
 ;; If you know of others, please email me!
 
 
 
 ;; vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
-;; End user interface
-
-;; vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
 ;; Package author interface variables
 
 (defvar reporter-prompt-for-summary-p nil
 variables.  Current buffer will always be the mail buffer being
 composed.")
 
-(defconst reporter-version "3.2"
+(defconst reporter-version "3.34"
   "Reporter version number.")
 
 (defvar reporter-initial-text nil
 (defun reporter-beautify-list (maxwidth compact-p)
   ;; pretty print a list
   (reporter-update-status)
-  (let (linebreak indent-enclosing-p indent-p here)
+  (let ((move t)
+	linebreak indent-enclosing-p indent-p here)
     (condition-case nil			;loop exit
 	(progn
 	  (down-list 1)
 	  (setq indent-enclosing-p t)
-	  (while t
+	  (while move
 	    (setq here (point))
-	    (forward-sexp 1)
+	    ;; The following line is how we break out of the while
+	    ;; loop, in one of two ways.  Either we've hit the end of
+	    ;; the buffer, in which case scan-sexps returns nil, or
+	    ;; we've crossed unbalanced parens and it will raise an
+	    ;; error we're expecting to catch.
+	    (setq move (scan-sexps (point) 1))
+	    (goto-char move)
 	    (if (<= maxwidth (current-column))
 		(if linebreak
 		    (progn
 	  (setq agent 'sendmail-user-agent
 		compose (get agent 'composefunc))
 	  (if (not (and compose (fboundp compose)))
-	      (error "Could not find a valid `mail-user-agent'.")
+	      (error "Could not find a valid `mail-user-agent'")
 	    (ding)
-	    (message "`%s' is an invalid `mail-user-agent'; using `sendmail-user-agent'."
+	    (message "`%s' is an invalid `mail-user-agent'; using `sendmail-user-agent'"
 		     mail-user-agent)
 	    )))
     (funcall compose)
       (pop-to-buffer mailbuf)
       ;; Just in case the original buffer is not visible now, bring it
       ;; back somewhere
-      (display-buffer reporter-eval-buffer))
+      (and pop-up-windows (display-buffer reporter-eval-buffer)))
     (goto-char (point-min))
     ;; different mailers use different separators, some may not even
     ;; use mail-header-separator, but sendmail.el stuff must have this
 		  (length reporter-initial-text))
 	       (string= (buffer-substring after-sep-pos (point))
 			reporter-initial-text))
-	  (error "Empty bug report cannot be sent."))
+	  (error "Empty bug report cannot be sent"))
       )))
 
 
-
 (provide 'reporter)
 ;;; reporter.el ends here